1480793 - Unable to add PWAs on Nightly

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Levente Sacal]

Device(s):
 -  Sony Xperia Z5 (Android 7.0);

Build(s):
 - Nightly 63.0a1 (2018-08-02)


Steps to reproduce:
 1. Go to Instragram or Twitter
 2. Try to add site as PWA to the home page 
 

Expected result:
- Websites can be added on Home page as PWAs.

Actual result:
- There is no shortcut button appearing next to the website

Notes:
- was not able to reproduce on Beta 62.0b13 or current Release

- reproducible on Sony Xperia Z5 (Android 7.0), OnePlus 3 (Android 6.0.1)
- not reproducible on Google Pixel XL (Android P), Samsung S8+ (Android 8.0)

Comment 1

[Kevin Brosnan [Ex-Mozilla]]

[Tracking Requested - why for this release]: regression in 63

Comment 2

[Brendan]

I'm having a similar issue. It worked fine until recently, I'm not sure which build. If I go into the menu and add it that way, it adds it to the home screen as a normal site shortcut, not a PWA. I'm on a Moto G6 Play (Android 8.0).

Comment 3

[Brendan]

I've tested the past few builds, the latest version where adding PWAs to the home screen works properly is from August 1st (http://ftp.mozilla.org/pub/mobile/nightly/2018/08/2018-08-01-10-01-14-mozilla-central-android-api-16/).

Comment 4

[Levente Sacal]

Regression window Sony Xperia Z5 (Android 7.0)

-last good build 2018-08-01
-first bad build 2018-08-02

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=af6a7edf0069549543f2fba6a8ee3ea251b20829&tochange=4146a5857135b8542858b9e23bc5a71237e05f49

Please let me know if any other info is needed. Thank you

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Copying Oana's work from bug 1480804 comment 2

Last known good build: 2018-08-01
First bad build: 2018-08-02

Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c918e687d594375e1964a68c9fceec8a08f61e59&tochange=2a5aa9de1fd9760a9245ecae815a6e02bb9eef42

2018-08-06T10:38:49: DEBUG : Using url: https://hg.mozilla.org/integration/mozilla-inbound/json-pushes?changeset=2a5aa9de1fd9760a9245ecae815a6e02bb9eef42&full=1
2018-08-06T10:38:50: DEBUG : Found commit message:
Bug 1479945: Part 5 - Remove the 'allowbootstrap' directive flag. r=froydnj

For all intents and purposes, this is now the same as the 'ischrome' flag.

Kris looks like you regressed this. Are you able to fix this or can you provide details so that that Petru Lingurar could?

Comment 7

[Mira Lobontiu (Android QA)]

Hi,

I was able to reproduce the issue.

Tested with:
Browser / Version: Firefox Mobile Nightly 63.0a1 (2018-08-09)
Operating System: 
 - Sony Xperia Z5 Premium (Android 6.0.1)
 - Google Pixel (Android 9.0)
 - Samsung Galaxy Note 8 (Android 8.0)
                      
Thank you!

Comment 8

[Jovan Gerodetti]

What is the priority of this? Can we expect a fix soon? 
I of course had the clever idea to choose Nightly as my daily driver and no I can't add any apps anymore.

Comment 9

[Ioana Chiorean]

Susheel, Andreas?

Comment 10

[:sdaswani]

Sounds like something we need to fix ASAP. I will wait to hear from Kris but adding to Softvision's work queue.

Comment 11

[Kris Maglione [:kmag]]

Someone who knows... anything about how PWAs work should probably look at this. I can only guess that they're loading chrome manifests in some unusual way, but beyond that, I don't even know where to start.

Comment 12

[Andreas Bovens [:abovens]]

I agree this should be fixed asap. 
Snorp might be able to assist here.

Comment 13

[David Bolter [:davidb] (NeedInfo me for attention)]

NI Susheel in case he missed followup comments.

Comment 14

[:sdaswani]

David my engineers don’t have much knowledge how PWAs work and it seems like that is something squarely in the Gecko sphere.

Comment 15

[strongthany]

I can recreate this issue myself
Browser / Version: Firefox Mobile Nightly 63.0a1 (2018-09-07)
Operating System: 
 - LG G6 VS988(Android 8.0.0)
    > kernel version: 3.18.71-perf+

Please let me know if there is any other testing I can do.

Comment 16

[Pascal Chevrel:pascalc]

(In reply to Andreas Bovens [:abovens] from comment #12)
> I agree this should be fixed asap. 

Andreas, David, is there somebody on the Gecko side (comment #14) that may be able to help resolve this regression? Thanks

Comment 17

[David Bolter [:davidb] (NeedInfo me for attention)]

Kris re: comment 11, could you join the #gv slack channel and see if you can get some interactive answers to help deeper diagnosis on the regression here? NI'ing Nick in case he has hunches.

Comment 18

[James Willcox (:snorp) ([e-mail]) (he/him)]

The change that broke this is https://hg.mozilla.org/mozilla-central/rev/fce8448381b4 from Bug 1479313. According to the comments in ActorManagerParent, it seems like this *should* be working, but the message sent here[0] never gets a response, so I'm guessing the fancy frame loading stuff isn't working. Kris, does the stuff in ActorManagerParent[1] look right to you?

[0] https://searchfox.org/mozilla-central/source/dom/manifest/ManifestObtainer.jsm#52
[1] https://searchfox.org/mozilla-central/source/toolkit/modules/ActorManagerParent.jsm#

Comment 19

[Kris Maglione [:kmag]]

OK, that makes much more sense than the original report

Comment 20

[Kris Maglione [:kmag]]

(In reply to James Willcox (:snorp) ([e-mail]) from comment #18)
> The change that broke this is
> https://hg.mozilla.org/mozilla-central/rev/fce8448381b4 from Bug 1479313.
> According to the comments in ActorManagerParent, it seems like this *should*
> be working, but the message sent here[0] never gets a response, so I'm
> guessing the fancy frame loading stuff isn't working. Kris, does the stuff
> in ActorManagerParent[1] look right to you?

I believe we need to remove the `"group": "browsers"`. We currently only load those actors into tabs on desktop. We could conceivably load them into tabs on Fennec as well, but I don't see any reason this actor should be restricted to tab browsers.

Comment 21

[Nick Alexander :nalexander [he/him]]

(In reply to Kris Maglione [:kmag] from comment #20)
> (In reply to James Willcox (:snorp) ([e-mail]) from comment #18)
> > The change that broke this is
> > https://hg.mozilla.org/mozilla-central/rev/fce8448381b4 from Bug 1479313.
> > According to the comments in ActorManagerParent, it seems like this *should*
> > be working, but the message sent here[0] never gets a response, so I'm
> > guessing the fancy frame loading stuff isn't working. Kris, does the stuff
> > in ActorManagerParent[1] look right to you?
> 
> I believe we need to remove the `"group": "browsers"`. We currently only
> load those actors into tabs on desktop. We could conceivably load them into
> tabs on Fennec as well, but I don't see any reason this actor should be
> restricted to tab browsers.

Locally this fixes the problem.  I'll try to work out the phab business to submit the review.

Comment 22

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1480793 - Process web manifest messages in Fennec. r?kmag

This restores "Add to home screen" functionality that was broken by
the restriction of these web manifest messages to "browser" groups in
Bug 1479313.

Comment 23

[Kris Maglione [:kmag]]

Comment on attachment 9008567 [details]
Bug 1480793 - Process web manifest messages in Fennec. r?kmag

Kris Maglione [:kmag] has approved the revision.

Comment 24

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1480793 - Fix Web Manifest fetching in Fennec r=kmag

Comment 25

[Kris Maglione [:kmag]]

Comment on attachment 9008568 [details]
Bug 1480793 - Fix Web Manifest fetching in Fennec r=kmag

Kris Maglione [:kmag] has approved the revision.

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc99c9e9db47
Fix Web Manifest fetching in Fennec r=kmag

Comment 27

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 9008568 [details]
Bug 1480793 - Fix Web Manifest fetching in Fennec r=kmag

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1479313
[User impact if declined]: Unable to add PWAs to homescreen
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: Yes, try adding a PWA (from pwa.rocks, for example) to the homescreen.
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: One-liner that re-enables previous functionality.
[String changes made/needed]: None

Comment 28

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/cc99c9e9db47

Comment 29

[Levente Sacal]

Verified as fixed in the latest Nightly 64.0a1 (2018-09-14) on Pixel XL (Android P) & Samsung S8+ (Android 8.0.0)

Comment 30

[Pascal Chevrel:pascalc]

Comment on attachment 9008568 [details]
Bug 1480793 - Fix Web Manifest fetching in Fennec r=kmag

Uplift approved for 63 beta 7

Comment 31

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4695938b717

Comment 32

[Stefan Deiac]

Verified as fixed in Firefox 63.0b7 on Nokia 6 (Android 7.1.1) and Samsung Galaxy S8 (Android 8.0.0).