1480814 - Add a pref to enable/disable top site search shortcuts on the newtab page

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Tim Spurway [:tspurway]]

browser.newtabpage.activity-stream.improve-search.top-site-search-short-cuts-enabled = boolean

The default should be true in beta, false in release 

This pref will be used by the Shield/Normandy infrastructure to run the experiment to pref the feature on

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4285

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/5687270d5e03d74e708c1d2bc5baa01bdccc376c
Fix Bug 1480814 - Add a pref to enable/disable top site search shortcuts on the newtab page

https://github.com/mozilla/activity-stream/commit/b1e9631a538ccccc8e37536780abe04ebb9021f3
Merge pull request #4285 from sarracini/bug_1480814

Fix Bug 1480814 - Add a pref to enable/disable top site search shortcuts on the newtab page

Comment 3

[Tim Spurway [:tspurway]]

(In reply to Tim Spurway [:tspurway] from comment #0)
> browser.newtabpage.activity-stream.improve-search.top-site-search-short-cuts-
> enabled = boolean
> 
> The default should be true in beta, false in release 
> 
> This pref will be used by the Shield/Normandy infrastructure to run the
> experiment to pref the feature on

NOTE:  the pref is actually browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f99759ea7410

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that the "browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts" boolean (by default with the "true" value) is displayed in the "about:config" page, on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180812220618) installed.

Also, I have verified that after the pref is set to "false", the top site search shortcuts are no longer displayed in the "Top Sites" area.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 7

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the "browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts" pref can be used to turn the search shortcut feature on and off in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.