1480887 - MozReview redirection service

Status: RESOLVED FIXED

(MozReview Graveyard :: General, enhancement)

Description

[Mark Côté [:mcote]]

Creating a service to redirect MozReview links, which may be in documents, browser histories, etc., to the appropriate alternative would be very convenient to developers.

The mapping should be as follows:

- review request to bug
- review request diff to review-repo commit
- review to bug comment

We can extract the necessary data from the Review Board and BMO databases.

Comment 1

[Mark Côté [:mcote]]

Attachment: Old MozReview URL redirection service

Comment 2

[Eric Shepherd [:sheppy]]

Is there any estimated timeframe for this being active? These links being broken is slowing down certain documentation work.

Comment 3

[Mark Côté [:mcote]]

I hope to have this up this week.  It likely won't include links to older diffs though, at least, for now.  I'll look into what would be required for that after the first part is up.

The commits have all been moved over to https://hg.mozilla.org/mozreview/<repo>, e.g. https://hg.mozilla.org/mozreview/gecko.  While we work on the redirect service, you can search commits (using gecko as an example) via https://hg.mozilla.org/mozreview/gecko/log?rev=<string>, where <string> is any string within a commit message.  For example, https://hg.mozilla.org/mozreview/gecko/log?rev=bug+1402334 to find commits for bug 1402334.  Or https://hg.mozilla.org/mozreview/gecko/log?rev=MozReview-Commit-ID:+KNUKL92aWcw to find all diffs, past and final, for the review request with mozreview commit ID KNUKL92aWcw.

Comment 4

[Mark Côté [:mcote]]

A first version of the redirect service is up at https://mr-redirect.herokuapp.com/.  It currently works for review request URLs and diff URLs (again only to the most recent commit for the moment).  Just substitutue "mr-redirect.herokupapp.com" for "reviewboard.mozilla.org" in MozReview URLs.

Once this service is reviewed, we'll switch the reviewboard.mozilla.org domain to point to it.

Comment 5

[Mark Côté [:mcote]]

Also note that the data in the service right now is from a couple weeks ago; the very latest commits before MozReview was shut down may not be reflected right now.  I'll be updating it soon.

Comment 6

[Mark Côté [:mcote]]

The service now has the latest data.  We should have the domain moved over next week I hope.

Comment 7

[:glob ✱]

Comment on attachment 8998945 [details]
Old MozReview URL redirection service

Byron Jones ‹:glob› 🎈 has approved the revision.

Comment 8

[Mark Côté [:mcote]]

This is now live at reviewboard.mozilla.org.

I haven't implemented review -> bug comment redirection since I was only working with the Review Board database, which doesn't have that info (BMO does).  However such links will still redirect to the correct bug, so we should be fine for now at least.  I can look at this later if it seems really useful.  For now I'm calling this done.