1481160 - Timezone labels in attendee dialog not aligned

Status: RESOLVED FIXED

(Calendar :: Dialogs, enhancement)

Description

[Richard Marti (:Paenglab)]

Attachment: attendee-dialog-timezone.png

The timezone labels aren't aligned in attendee dialog.

In TB 52 and 60 only the from timezone is shown the to is collapsed. Either this will be collapsed too in Daily or we need to align the labels properly.

I think we should collapse like it was before as it makes not much sense to change the timezone during a meeting.

Comment 1

[Geoff Lankow (:darktrojan)]

I also see this in 60, FWIW, and I think I know why: the end timezone is hidden if the timezones are the same, but the way we compare timezones is terrible.

Comment 2

[Richard Marti (:Paenglab)]

Then it it could be also fixed by CSS. It is defined here https://searchfox.org/comm-central/source/calendar/base/themes/linux/dialogs/calendar-event-dialog.css#13 to align it behind the time lock button.

Comment 3

[Geoff Lankow (:darktrojan)]

We shouldn't even be using that stylesheet on this dialog. It has nothing we want. :/

Comment 4

[Geoff Lankow (:darktrojan)]

Attachment: 1481160-timezone-labels-1.diff

Comment 5

[Richard Marti (:Paenglab)]

Comment on attachment 8997835 [details] [diff] [review]
1481160-timezone-labels-1.diff

This fixes the issue. r+ with my comment considered.

There are styles for the attendee dialog in https://searchfox.org/comm-central/source/calendar/base/themes/common/dialogs/calendar-event-dialog.css#317-448 that should be considered to move to calendar-attendee.css. They need also some tuning to work after the listbox conversion.

Comment 6

[Geoff Lankow (:darktrojan)]

That is such a mess I've filed bug 1481339 to deal with it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd114840e2d8
fix alignment of timezone labels in attendee dialog. r=Paenglab