1481438 - Horizontal scrollbar when nick name is too long

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

In Chat's participant list (the one on the right) when a nick is longer than the width of the list a horizontal scrollbar appears. We should crop this name instead.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: cropNick.patch

This can be tested in maildev where a user with lots of "a" exists.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8998159 [details] [diff] [review]
cropNick.patch

Looks good, I didn't test it. TB 60 already does the cropping, so that's a regression, most likely from the listbox stuff, right?

So if it works in TB 60, is it done via CSS there? And has that CSS been removed or should be removed? Or why why did it stop working? Should the CSS be adjusted instead of doing JS stuff here?

Comment 3

[Richard Marti (:Paenglab)]

Yes, it's a regression from the listbox conversion. It's not done through CSS but, I think, automatically by the listbox stuff.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8998159 [details] [diff] [review]
cropNick.patch

OK. Please double-check that there was really no CSS involved.

Comment 5

[Richard Marti (:Paenglab)]

Checked, the listcell-label has flex="1" crop="right" in its attributes and no CSS for this. We use crop="end" to be sure it works on RTL too. The listcell-label crop is set automatically by the listbox stuff, so this should work correctly too on RTL.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/22406f6836c1
Crop the nickname when it is too long. r=jorgk