Closed Bug 1481593 Opened 6 years ago Closed 6 years ago

With `-moz-appearance: none`, Firefox doesn't get rid of the <input type=range> track like Chrome does

Categories

(Core :: Layout, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: jwatt, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

With `-moz-appearance: none`, Firefox doesn't get rid of the <input type=range> track like Chrome does. Probably this isn't that important for web content.
I think this caused https://github.com/webcompat/web-bugs/issues/8592 .
The site has changed since then though and seems to be working now.
It appears they are now using a bunch of <div>s to implement
a home-grown form control.  Sigh, poor a11y users...
Attached file Testcase
We're also incompatible when the element has a 'border' or 'background'...
Assignee: nobody → mats
Attached patch fix+testSplinter Review
This patch addresses the background/theme incompatibilities.
It makes us render the attached testcase roughly the same as
Chrome/Safari.

I also noticed that our margin is excessive compared to other
UAs, and that the intrinsic sizing has some bugs, but I'll
address those in a separate follow-up bug.
Attachment #9024969 - Flags: review?(jwatt)
Comment on attachment 9024969 [details] [diff] [review]
fix+test

Review of attachment 9024969 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Mats!
Attachment #9024969 - Flags: review?(jwatt) → review+
Fwiw, I just found this about the range control in various UAs:
https://css-tricks.com/sliding-nightmare-understanding-range-input/
lot's of interesting details and peculiarities...
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ec28a9a202
Make <input type=range> layout more compatible with WebKit/Blink.  r=jwatt
Flags: in-testsuite+
https://hg.mozilla.org/mozilla-central/rev/17ec28a9a202
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Depends on: 1524573
Regressions: 1572923
Regressions: 1583660
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: