Closed Bug 1481680 Opened Last year Closed Last year
Add mochitests for search shortcuts and fix existing mochitests
52 bytes, text/x-github-pull-request
|Details | Review|
(See https://github.com/mozilla/activity-stream/pull/4289) Having the search shortcuts experiment turned on by default messes up the existing mochitests; by adding pinned search shortcuts we change the TopSites behaviour (e.g., positions of default sites, number of sites, number of pinned sites) and the tests fail. For the linked PR we disable the experiment for the tests. We should fix the existing tests and re-enable the experiment for them, and also add new mochitests to cover the behaviour of the new search shortcuts.
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/616f95fe7942f9818a8635d7e13b6b37292b3c93 fix(tests): Revert #4289 head.js changes to turn off pref from browser.ini Disable pref until bug 1481680
Ha oops. My simple grep accidentally found a commit message comment "Disable pref until bug 1481680" This is not fixed in 62.
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/b31a327a49a1531505cbc48b1f93070291cac8ef Fix Bug 1481680 - Add mochitests for search shortcuts and fix existing mochitests
Is this something we want to uplift to Beta. It's test-only, so it could be uplifted without approval.
This got backed out unfortunately, we're working on re-landing.
Backout by firstname.lastname@example.org: https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout Relanded: https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
Ping RE: Beta uplift - worth it with a week left before the RC?
QA Contact: tspurway
I wouldn't uplift this since we already had the backout issue. Thanks.
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.