Closed
Bug 1481680
Opened 6 years ago
Closed 6 years ago
Add mochitests for search shortcuts and fix existing mochitests
Categories
(Firefox :: New Tab Page, enhancement, P3)
Firefox
New Tab Page
Tracking
()
People
(Reporter: ahillier, Assigned: andreio)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(See https://github.com/mozilla/activity-stream/pull/4289)
Having the search shortcuts experiment turned on by default messes up the existing mochitests; by adding pinned search shortcuts we change the TopSites behaviour (e.g., positions of default sites, number of sites, number of pinned sites) and the tests fail.
For the linked PR we disable the experiment for the tests. We should fix the existing tests and re-enable the experiment for them, and also add new mochitests to cover the behaviour of the new search shortcuts.
|
||
Updated•6 years ago
|
Iteration: --- → 63.4 - Aug 20
Priority: -- → P3
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → andrei.br92
|
||
Comment 1•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/616f95fe7942f9818a8635d7e13b6b37292b3c93
fix(tests): Revert #4289 head.js changes to turn off pref from browser.ini
Disable pref until bug 1481680
|
|
||
Updated•6 years ago
|
Severity: normal → enhancement
|
||
Comment 2•6 years ago
|
||
|
||
Comment 3•6 years ago
|
||
| incorrect | ||
status-firefox62:
--- → fixed
|
|
||
Comment 4•6 years ago
|
||
Ha oops. My simple grep accidentally found a commit message comment "Disable pref until bug 1481680" This is not fixed in 62.
status-firefox62:
fixed → ---
|
||
Updated•6 years ago
|
Iteration: 63.4 - Aug 20 → 63.5 - Sep 3
status-firefox63:
--- → affected
|
|
||
Updated•6 years ago
|
Iteration: 63.5 - Sep 3 → 64.1 (Sep 14)
|
|
||
Comment 5•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/b31a327a49a1531505cbc48b1f93070291cac8ef
Fix Bug 1481680 - Add mochitests for search shortcuts and fix existing mochitests
|
|
||
Updated•6 years ago
|
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
||
Comment 6•6 years ago
|
||
status-firefox64:
--- → fixed
Target Milestone: --- → Firefox 64
|
||
Comment 7•6 years ago
|
||
Is this something we want to uplift to Beta. It's test-only, so it could be uplifted without approval.
Flags: needinfo?(andrei.br92)
|
|
Assignee | |
Comment 8•6 years ago
|
||
This got backed out unfortunately, we're working on re-landing.
Flags: needinfo?(andrei.br92)
|
|
||
Comment 9•6 years ago
|
||
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout
Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
|
|
||
Comment 10•6 years ago
|
||
Ping RE: Beta uplift - worth it with a week left before the RC?
Flags: needinfo?(andrei.br92)
QA Contact: tspurway
|
|
Assignee | |
Comment 11•6 years ago
|
||
I wouldn't uplift this since we already had the backout issue. Thanks.
Flags: needinfo?(andrei.br92)
|
||
Updated•6 years ago
|
QA Contact: tspurway
|
|
||
Updated•6 years ago
|
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•