1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[Ed Lee :Mardak]

Attachment: Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream

Comment 2

[Ed Lee :Mardak]

Ah, we have some unreferenced pocket tagger files:

  FAIL unreferenced file: resource://activity-stream/lib/NaiveBayesTextTagger.jsm - 
  FAIL unreferenced file: resource://activity-stream/lib/NmfTextTagger.jsm - 
  FAIL unreferenced file: resource://activity-stream/lib/TfIdfVectorizer.jsm -

Comment 3

[Kate Hudson :k88hudson]

Comment on attachment 9009283 [details]
Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream

Kate Hudson :k88hudson has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8dde92f89a24
Add snippets targeting, Pocket tagging and bug fixes to Activity Stream r=k88hudson

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8dde92f89a24

Comment 6

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures.

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedJob=200295332&revision=9812141ec78239560283181ce610249d181b74b6

Backout link: https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d699255cd37df187f058a1b5a8423

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=200295332&repo=mozilla-central&lineNumber=3599

[task 2018-09-19T23:17:12.096Z] 23:17:12     INFO - TEST-START | browser/components/newtab/test/browser/browser_asrouter_cfr.js
[task 2018-09-19T23:17:12.102Z] 23:17:12     INFO - TEST-INFO | started process screentopng
[task 2018-09-19T23:17:12.761Z] 23:17:12     INFO - TEST-INFO | screentopng: exit 0
[task 2018-09-19T23:17:12.762Z] 23:17:12     INFO - Buffered messages logged at 23:17:12
[task 2018-09-19T23:17:12.764Z] 23:17:12     INFO - Entering test bound test_cfr_notification_show
[task 2018-09-19T23:17:12.766Z] 23:17:12     INFO - Buffered messages finished
[task 2018-09-19T23:17:12.767Z] 23:17:12     INFO - TEST-UNEXPECTED-FAIL | browser/components/newtab/test/browser/browser_asrouter_cfr.js | Uncaught exception - at chrome://browser/content/browser.js:1047 - Error: Must load with a triggering Principal
[task 2018-09-19T23:17:12.769Z] 23:17:12     INFO - Stack trace:
[task 2018-09-19T23:17:12.770Z] 23:17:12     INFO - _loadURI@chrome://browser/content/browser.js:1047:11
[task 2018-09-19T23:17:12.770Z] 23:17:12     INFO - test_cfr_notification_show@chrome://mochitests/content/browser/browser/components/newtab/test/browser/browser_asrouter_cfr.js:46:3
[task 2018-09-19T23:17:12.772Z] 23:17:12     INFO - Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:1102:34
[task 2018-09-19T23:17:12.772Z] 23:17:12     INFO - async*Tester_execTest@chrome://mochikit/content/browser-test.js:1093:16
[task 2018-09-19T23:17:12.773Z] 23:17:12     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:995:9
[task 2018-09-19T23:17:12.774Z] 23:17:12     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
[task 2018-09-19T23:17:12.775Z] 23:17:12     INFO - Leaving test bound test_cfr_notification_show
[task 2018-09-19T23:17:12.778Z] 23:17:12     INFO - GECKO(3756) | MEMORY STAT | vsize 1694MB | residentFast 296MB | heapAllocated 117MB
[task 2018-09-19T23:17:12.780Z] 23:17:12     INFO - TEST-OK | browser/components/newtab/test/browser/browser_asrouter_cfr.js | took 55ms

Comment 8

[Kate Hudson :k88hudson]

Comment on attachment 9009283 [details]
Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream

Kate Hudson :k88hudson has requested changes to the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/581019e9ea70
Add snippets targeting, Pocket tagging and bug fixes to Activity Stream r=Mardak

Comment 10

[Ed Lee :Mardak]

Comment on attachment 9009283 [details]
Bug 1489962 - Add snippets targeting, Pocket tagging and bug fixes to Activity Stream

Ed Lee :Mardak (PTO Sep 15 - Oct 7) has approved the revision.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/581019e9ea70

Comment 12

[Ed Lee :Mardak]

This was relanded with a fix for the merge conflict of inbound changes to API.