Closed
Bug 1481700
Opened 7 years ago
Closed 7 years ago
Regression: Multi-selection with Shift key is broken because of patch from bug 1458066
Categories
(Firefox :: Tabbed Browser, defect, P1)
Firefox
Tabbed Browser
Tracking
()
VERIFIED
FIXED
Firefox 63
People
(Reporter: ablayelyfondou, Assigned: ablayelyfondou, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: regression)
Attachments
(1 file, 3 obsolete files)
To reproduce the bug:
1. Open 4 tabs A,B,C,D with A having the focus
2. Select all tabs by clicking on D while holding Shift
3. Click on B while holding on Shift
Expected result:
A and B selected, C and D not selected.
Actual result:
All tabs (A,B,C,D) are still selected.
Assignee | ||
Updated•7 years ago
|
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ablayelyfondou
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: FslyILLXMrj
Assignee | ||
Updated•7 years ago
|
Attachment #8998410 -
Attachment is obsolete: true
Assignee | ||
Comment 2•7 years ago
|
||
MozReview-Commit-ID: FslyILLXMrj
Assignee | ||
Updated•7 years ago
|
Attachment #8998411 -
Flags: review?(jaws)
Comment 3•7 years ago
|
||
Comment on attachment 8998411 [details] [diff] [review]
Release clear-selection lock when 'mouseup' event is fired for tabs
Review of attachment 8998411 [details] [diff] [review]:
-----------------------------------------------------------------
::: browser/base/content/tabbrowser.xml
@@ +2061,5 @@
> ]]>
> </handler>
> <handler event="mouseup">
> + // Make sure that clear-selection is released.
> + // Otherwise Selection using Shift key may be broken (bug 1481700).
You can remove the bug number here since hg blame will provide a reference to what bug added this.
Attachment #8998411 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 4•7 years ago
|
||
MozReview-Commit-ID: FslyILLXMrj
Assignee | ||
Updated•7 years ago
|
Attachment #8998411 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8998413 -
Flags: review?(jaws)
Updated•7 years ago
|
Attachment #8998413 -
Flags: review?(jaws) → review+
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0bcce164a404
Release clear-selection lock when 'mouseup' event is fired for tabs. r=jaws
Keywords: checkin-needed
Comment 6•7 years ago
|
||
Backed out changeset 0bcce164a404 (Bug 1481700) failure at browser/base/content/test/tabs/browser_multiselect_tabs_using_Shift.js
Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/09719705be5d95c70851e65fb60ce303dabb3a13
Push link:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=0bcce164a404b4a53f123bdf87f2db645a3c8548&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified
Failure log:
https://treeherder.mozilla.org/logviewer.html#?job_id=192837032&repo=mozilla-inbound&lineNumber=7638
[task 2018-08-08T18:19:48.360Z] 18:19:48 INFO - TEST-PASS | browser/base/content/test/tabs/browser_multiselect_tabs_event.js | Got TabMultiSelect event -
[task 2018-08-08T18:19:48.361Z] 18:19:48 INFO - Buffered messages finished
[task 2018-08-08T18:19:48.362Z] 18:19:48 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_event.js | Check number of selected tabs - Got 1, expected 3
[task 2018-08-08T18:19:48.362Z] 18:19:48 INFO - Stack trace:
[task 2018-08-08T18:19:48.363Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:test_is:1308
[task 2018-08-08T18:19:48.364Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:expectSelected:39
[task 2018-08-08T18:19:48.364Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:expectEvent:27
[task 2018-08-08T18:19:48.365Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:clickWithPrefSet:91
[task 2018-08-08T18:19:48.365Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2018-08-08T18:19:48.366Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2018-08-08T18:19:48.366Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
[task 2018-08-08T18:19:48.367Z] 18:19:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-08-08T18:19:48.368Z] 18:19:48 INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-08-08T18:19:48.373Z] 18:19:48 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/tabs/browser_multiselect_tabs_event.js | Check the selected tab #1 - Got [object XULElement], expected [object XULElement]
[task 2018-08-08T18:19:48.374Z] 18:19:48 INFO - Stack trace:
[task 2018-08-08T18:19:48.375Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:test_is:1308
[task 2018-08-08T18:19:48.376Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:expectSelected:41
[task 2018-08-08T18:19:48.377Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:expectEvent:27
[task 2018-08-08T18:19:48.378Z] 18:19:48 INFO - chrome://mochitests/content/browser/browser/base/content/test/tabs/browser_multiselect_tabs_event.js:clickWithPrefSet:91
[task 2018-08-08T18:19:48.385Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
[task 2018-08-08T18:19:48.386Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
[task 2018-08-08T18:19:48.386Z] 18:19:48 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
[task 2018-08-08T18:19:48.387Z] 18:19:48 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-08-08T18:19:48.388Z] 18:19:48 INFO - Clearing multiselection with click should trigger event
Flags: needinfo?(ablayelyfondou)
Assignee | ||
Comment 7•7 years ago
|
||
Reapply backed out changetset with 'browser/base/content/test/tabs/multiselect_tabs_event.js' tests fixed.
Comment 8•7 years ago
|
||
Comment on attachment 8998940 [details]
Bug 1481700 - Release clear-selection lock when 'mouseup' event is fired for tabs. r?jaws
Jared Wein [:jaws] (please needinfo? me) has approved the revision.
Attachment #8998940 -
Flags: review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f6a722db7b3
Release clear-selection lock when 'mouseup' event is fired for tabs. r=jaws
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(ablayelyfondou)
Assignee | ||
Updated•7 years ago
|
Attachment #8998413 -
Attachment is obsolete: true
Comment 10•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Keywords: regression
Comment 11•6 years ago
|
||
Verified fixed in latest nightly 65.0a1(2018-11-11) and latest Beta 64.0b8 on Windows 10x64, macOS 10.13 and Ubuntu 16.04x64.
You need to log in
before you can comment on or make changes to this bug.
Description
•