1481776 - Refactor Marionette code to it's own module

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Once the Serde patch landed via bug 1396821 most of the ToMarionette traits might not be necessary anymore, or would need some changes.

I assume that we still want to keep the data structures between the webdriver protocol, and Marionette separate. In that case we would have to create new types and help Serde to serialize those.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Ideally there should be a Marionette Rust crate that is separated
from geckodriver.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With separate data structures as expected by Marionette? Sounds fine to me.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: [geckodriver] Move WebDriver related code into the command module

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=832f8df84e9a8ea323a1dae4d2b480a0d7cf04d1

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9004233 [details] [diff] [review]
[geckodriver] Move WebDriver related code into the command module

Missed that James is out today. Andreas, if you have the time feel free to pick it up. Otherwise we will wait. Thanks.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9004233 [details] [diff] [review]
[geckodriver] Move WebDriver related code into the command module

Review of attachment 9004233 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Andreas!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb80a4f44ac2
[geckodriver] Move WebDriver related code into the command module. r=ato

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/fb80a4f44ac2