Closed Bug 1466818 Opened 2 years ago Closed 2 years ago

Release geckodriver 0.22.0

Categories

(Testing :: geckodriver, enhancement, P1)

enhancement

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: ato, Assigned: ato)

References

(Blocks 1 open bug)

Details

Attachments

(3 files, 1 obsolete file)

No description provided.
Depends on: 1433495
Depends on: 1461608
Depends on: 1410838
Depends on: 1421766
Depends on: 1403510
Depends on: 1401131
Depends on: 1406006
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: -- → P1
Assignee: ato → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3
Depends on: 1471201
Blocks: 1489130
Postponing some features to 0.23.0.
No longer depends on: 1401131, 1403510, 1410838, 1421766, 1433495
Assignee: nobody → ato
Status: NEW → ASSIGNED
Priority: P3 → P1
Attachment #9009118 - Flags: review?(hskupin)
We should redirect
https://github.com/mozilla/geckodriver/wiki/Geckodriver-Releases
when this is available on firefox-source-docs.m.o.
Attachment #9009119 - Flags: review?(hskupin)
Attachment #9009120 - Flags: review?(hskupin)
Attachment #9009124 - Flags: review?(hskupin)
Attachment #9009120 - Attachment is obsolete: true
Attachment #9009120 - Flags: review?(hskupin)
Comment on attachment 9009118 [details] [diff] [review]
geckodriver: update changelog

Review of attachment 9009118 [details] [diff] [review]:
-----------------------------------------------------------------

This is a huge number of fixes and improvements! But those are not all. Please go through the following list of bugs until you reach the 0.21.0 release bug, and make sure to add the remaining ones like increasing the timeout for keep-alive.

::: testing/geckodriver/CHANGES.md
@@ +9,5 @@
> +
> +This release marks an important milestone on the path towards
> +a stable release of geckodriver.  Large portions of geckodriver
> +and the [webdriver] library it is based on has been refactored to
> +accommodate using [serde] for JSON serialization.

To be fully correct here we also have to add deserialization.

@@ +66,5 @@
> +- The `marionette.log.level` preference that geckodriver writes to the
> +  profile before starting Firefox is now appropriately formatted so that
> +  Marionette can make use of a dynamic way to track the current log level.
> +
> +- Dropped `sessionId` validation from Marionette.

That's not something we have to list here for geckodriver/webdriver changes, or?

@@ +71,5 @@
> +
> +- Duplication of capabilities inside a `capabilities` field when
> +  requesting a new WebDriver session with Marionette has been dropped.
> +
> +- The webdriver library has been updated to version 0.37.0.

Better crate than library? But not sure which word is usually used.
Attachment #9009118 - Flags: review?(hskupin) → review+
Comment on attachment 9009119 [details] [diff] [review]
geckodriver: put compat table in docs

Review of attachment 9009119 [details] [diff] [review]:
-----------------------------------------------------------------

I would suggest that we leave this in the wiki simply due to the fact that I want to avoid having multiple versions due to our branching, and that we might have to make changes even weeks after a release. This will be confusing when it's under version control.
Attachment #9009119 - Flags: review?(hskupin) → review-
Attachment #9009124 - Flags: review?(hskupin) → review+
(In reply to Henrik Skupin (:whimboo) from comment #6)
> This is a huge number of fixes and improvements! But those are not all.
> Please go through the following list of bugs until you reach the 0.21.0
> release bug, and make sure to add the remaining ones like increasing the
> timeout for keep-alive.

I missed to add the link to the list of fixes:

https://bugzilla.mozilla.org/buglist.cgi?list_id=14333937&resolution=FIXED&query_format=advanced&bug_status=RESOLVED&component=geckodriver&product=Testing
Comment on attachment 9009118 [details] [diff] [review]
geckodriver: update changelog

Review of attachment 9009118 [details] [diff] [review]:
-----------------------------------------------------------------

The fix for Keep-Alive is already mentioned in the changelog.

I went through the commits made since 0.21.0’s release date in
testing/geckodriver, testing/webdriver, and testing/mozbase/rust.
I think that covers everything.

Do you have any you think are missing?

::: testing/geckodriver/CHANGES.md
@@ +9,5 @@
> +
> +This release marks an important milestone on the path towards
> +a stable release of geckodriver.  Large portions of geckodriver
> +and the [webdriver] library it is based on has been refactored to
> +accommodate using [serde] for JSON serialization.

That is sort of implied.

@@ +66,5 @@
> +- The `marionette.log.level` preference that geckodriver writes to the
> +  profile before starting Firefox is now appropriately formatted so that
> +  Marionette can make use of a dynamic way to track the current log level.
> +
> +- Dropped `sessionId` validation from Marionette.

I hesitated, but I can drop these.
Comment on attachment 9009119 [details] [diff] [review]
geckodriver: put compat table in docs

Review of attachment 9009119 [details] [diff] [review]:
-----------------------------------------------------------------

That is true for any change that goes into central and later gets
uplifted to beta.  The point is that firefox-source-docs.m.o is
built from central, so what we would be presenting to the average
end-user would have the latest and correct information.

If a users were to look at this file on the beta branch, they would
see the current up-to-date information for that branch.  It might
not contain when a particular geckodriver was deprecated for which
Firefox version, but you wouldn’t expect that in older documentation.

We also won’t continue releasing from GitHub forever.  It would be
better to concentrate documentation in one location, instead of
having one piece of obscure documentation in the wiki (hardly easily
found) and some in another.
Comment on attachment 9009118 [details] [diff] [review]
geckodriver: update changelog

Review of attachment 9009118 [details] [diff] [review]:
-----------------------------------------------------------------

> The fix for Keep-Alive is already mentioned in the changelog.

I don't see it mentioned that we increased the drop timeout from 5s to 60s. The one which is in the changelog is for the timeout error.

> Do you have any you think are missing?

Beside the above only bug 1467700. Otherwise it looks fine. Please see the inline notes too.

::: testing/geckodriver/CHANGES.md
@@ +66,5 @@
> +- The `marionette.log.level` preference that geckodriver writes to the
> +  profile before starting Firefox is now appropriately formatted so that
> +  Marionette can make use of a dynamic way to track the current log level.
> +
> +- Dropped `sessionId` validation from Marionette.

If this code is Marionette only we should drop. But if it also caused side-effects for geckodriver we should leave it as is.

@@ +1017,2 @@
>  [mozrunner crate]: https://crates.io/crates/mozrunner
> +[serde]: https://github.com/serde-rs/serde

Similar to hyper please use the project website which is https://serde.rs/
Comment on attachment 9009119 [details] [diff] [review]
geckodriver: put compat table in docs

Review of attachment 9009119 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, makes sense. I didn't thought about the fact that we ultimatively want to get rid of using the Github repository. So lets get this in and we will see how it works.

I don't think the 2nd paragraph in the commit message is actually necessary. Just tag the bug with the keyword `leave-open`, and we can do the redirect then.
Attachment #9009119 - Flags: review- → review+
OK thanks, I believe I’ve addressed all the points you’ve raised now.
It appears the trees are closed at this time:
https://bugzilla.mozilla.org/show_bug.cgi?id=1491550
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3893b3ec36b7
geckodriver: update changelog; r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a2f52692805
geckodriver: put compat table in docs; r=whimboo
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba6208ac98c6
geckodriver: release version 0.22.0; r=whimboo
Pushed by ato@sny.no:
https://hg.mozilla.org/integration/mozilla-inbound/rev/95855da9e698
mozrunner: depend on in-tree mozprofile; r=me
You need to log in before you can comment on or make changes to this bug.