Closed Bug 148194 Opened 18 years ago Closed 11 years ago

Remove session-logout code from security module

Categories

(Core Graveyard :: Security: UI, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1a2

People

(Reporter: morse, Assigned: sgautherie)

References

Details

(Whiteboard: [kerh-cuz])

Attachments

(1 file)

As a result of the patch in bug 98673, the session-logout signal is no longer 
being issued.  The code for handling that signal should be removed.

This occurs in the following place

/security/manager/ssl/src/nsNSSComponent.cpp, line 1351 -- #define 
SESSION_LOGOUT_TOPIC NS_LITERAL_CSTRING("session-logout").get()
->PSM
Assignee: mstoltz → ssaux
Component: Security: General → Client Library
Product: Browser → PSM
QA Contact: bsharma → junruh
Version: other → 2.2
kai
Assignee: ssaux → kaie
Priority: -- → P2
Target Milestone: --- → 2.3
This has a negative consequence:

At the time that event was received, we would log the user out of any security
devices in use. That includes the software device and any hardware tokens.

If we no longer do that, the tokens will still be logged in. The log out
behaviour was initially requested in bug 101263 and I think it is reasonable.

Is there another event we could listen to alternatively?

Product: PSM → Core
Whiteboard: [kerh-cuz]
changing obsolete psm* target to --- (unspecified)
Target Milestone: psm2.3 → ---
QA Contact: junruh → ui
Depends on: 98673
<http://mxr.mozilla.org/seamonkey/search?string=session-logout&case=on&find=%5C.cpp%24&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey>
{{
/security/manager/ssl/src/nsNSSComponent.cpp
    * line 1954 -- #define SESSION_LOGOUT_TOPIC "session-logout"
}}

<http://mxr.mozilla.org/seamonkey/search?string=SESSION_LOGOUT_TOPIC&case=on&find=%2Fssl%2Fsrc%2FnsNSSComponent.cpp&filter=%5E%5B%5E%5C0%5D*%24&tree=seamonkey>
{{
/security/manager/ssl/src/nsNSSComponent.cpp
    * line 1954 -- #define SESSION_LOGOUT_TOPIC "session-logout"
    * line 2041 -- else if ((nsCRT::strcmp(aTopic, SESSION_LOGOUT_TOPIC) == 0) && mNSSInitialized) {
    * line 2179 -- observerService->AddObserver(this, SESSION_LOGOUT_TOPIC, PR_FALSE);
}}
Flags: wanted1.9.1?
Keywords: privacy, regression
Whiteboard: [kerh-cuz] → [kerh-cuz] [regression: comment 3]
(In reply to comment #3)
> Is there another event we could listen to alternatively?

<http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/xpfe/bootstrap/nsNativeAppSupportWin.cpp&rev=1.124.2.9&mark=2745,2758#2730>

1.8(.1) branch </xpfe/*> code:
bug 98673 fix is creating a new process and quitting the current one.
I would guess/hope we are already getting some other event which somehow triggers the security log out code too.
Or would that be the other event we are looking for ?

<http://mxr.mozilla.org/mozilla/source/toolkit/xre/nsNativeAppSupportWin.cpp>

1.9(.0) trunk(/branch) </toolkit/*> code:
"Bug 361682 – Remove "turbo mode" from suiterunner builds" says it all.
Depends on: 361682
Priority: P2 → --
Assignee: kaie → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #326000 - Flags: review?(kaie)
Version: psm2.2 → 1.0 Branch
Kaie, ping ?

(NB: This is the last occurrence of such code.)
OS: Windows NT → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9.1a2
Version: 1.0 Branch → Trunk
Comment on attachment 326000 [details] [diff] [review]
(Av1-19T) <nsNSSComponent.cpp>
[Checkin: Comment 10]

r=kaie
Attachment #326000 - Flags: review?(kaie) → review+
Flags: in-testsuite-
Keywords: checkin-needed
Pushed as 17115:4227664954fd.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Attachment #326000 - Attachment description: (Av1-19T) <nsNSSComponent.cpp> → (Av1-19T) <nsNSSComponent.cpp> [Checkin: Comment 10]
Severity: normal → trivial
Flags: wanted1.9.1?
Keywords: privacy, regression
Whiteboard: [kerh-cuz] [regression: comment 3] → [kerh-cuz]
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.