Closed Bug 361682 Opened 14 years ago Closed 13 years ago
Remove "turbo mode" from suiterunner builds
27.30 KB, patch
|Details | Diff | Splinter Review|
9.92 KB, patch
|Details | Diff | Splinter Review|
Turbo mode won't work with suiterunner builds on windows or macs (never implemented on linux I believe). We need to either a) remove the dialogs/code completely (and hence drop support for it) b) find a way to hook in before profile selection and restore the turbo mode functionality.
I think the real turbo mode is something we probably should remove, but with something like that "minimaize to try" stuff and bug 325353 we could probably build a modern replacement for it...
Morphing the bug description into removing "turbo mode". If we want to follow the path I pointed to in comment #1, we should file a new bug about that. The old turbo stuff needs to go away though.
Summary: Turbo mode won't work with suiterunner builds → Remove "turbo mode" from suiterunner builds
I just found this bug, and seeing mine at Bug 383161 – keep in memory (turbo mode?) for faster startup not working we can probably mark 361682 as fixed.
Hmm, it would be nice if someone could pick this up and remove the turbo stuff for now, it's just unused cruft nowadays.
This patch removes code related to "turbo mode" from suite/ (excluding the Help files, those will be changed in an extra patch). What's also missing from the patch is the removal of /suite/themes/classic/communicator/icons/turbo-systray.gif and /suite/themes/modern/communicator/icons/turbo-systray.gif (haven't figured out, how to remove those with cvsdo remove).
This patch removes all occurrences of quick launch from the help files. What should probably go into another bug is the problem, that we only have "Enable Java" in the Advanced pref pane after quick launch is removed. Perhaps that should be moved somewhere else and Advanced should contain an explanatory text like Privacy & Security.
(In reply to comment #7) > (haven't figured out, > how to remove those with cvsdo remove). I might be wrong, but I think you can just do a diff once you've done the cvsdo remove. I won't be able to look at this until I have my new hardware (should get it next week, though)
Comment on attachment 282859 [details] [diff] [review] Remove "turbo mode" related code from suite/ (In reply to comment #7) >(haven't figured out, how to remove those with cvsdo remove). You can't really, they're binary files, the best you can do is generate "Binary files surbo-systray.gif and /dev/null differ". (In reply to comment #8) >What should probably go into another bug is the problem, that we only have >"Enable Java" in the Advanced pref pane after quick launch is removed. That's not true on Linux, where iirc you have JVM and system preferences.
Attachment #282859 - Flags: superreview?(neil) → superreview+
Missed one occurence, thx stefanh! Neil, do you have Windows to have a look at the sight from a windows user? Stefanh won't see the win related changes in the help files and can only check if it looks ok in non-windows systems.
Comment on attachment 282859 [details] [diff] [review] Remove "turbo mode" related code from suite/ Looks good to me, though I can't test this on Windows.
Attachment #282859 - Flags: review?(kairo) → review+
Comment on attachment 282895 [details] [diff] [review] Remove "all" Quick Launch from help files - <p>Once &brandShortName; Mail has been started, the new message alert will - continue to work even after you close the Mail window (as long as another - &brandShortName; application is running).</p> + <p>If any &brandShortName; application is running the new message alert will + continue to work even after you close the Mail window. + </p> Keep the old sentence, but remove the "Once..." section: "The new message alert will - continue to work even after you close the Mail window (as long as another - &brandShortName; application is running)." r=me by code inspection only
Attachment #282895 - Flags: review?(stefanh) → review+
Not sure what happened with the last post, but here's a clarification: "The new message alert will continue to work even after you close the Mail window (as long as another &brandShortName; application is running)."
Comment on attachment 282895 [details] [diff] [review] Remove "all" Quick Launch from help files >Index: suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml >=================================================================== >RCS file: /cvsroot/mozilla/suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml,v >retrieving revision 1.49 >diff -u -8 -p -r1.49 cs_nav_prefs_advanced.xhtml >--- suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml 16 Jun 2007 13:53:36 -0000 1.49 >+++ suite/locales/en-US/chrome/common/help/cs_nav_prefs_advanced.xhtml 30 Sep 2007 17:00:28 -0000 >@@ -47,27 +47,22 @@ > > <ol> > <li>Open the <span class="mac">&brandShortName;</span> > <span class="noMac">Edit</span> menu and choose Preferences.</li> > <li>Click the Advanced category.</li> > </ol> > > <p>The main Advanced preferences panel allows you to enable or disable >- Java<span class="win"> and Quick Launch</span>:</p> >+ Java:</p> > > <ul> > <li><strong>Enable Java</strong>: Select this to allow &brandShortName; to > interpret pages containing Java. Java is used on some Web page to > incorporate interactive and multimedia content.</li> >- <li class="win"><strong>Keep &brandShortName; in memory to improve startup >- performance</strong>: Select this if you want to shorten the time it takes >- to start &brandShortName;. See >- <q><a href="nav_help.xhtml#using_quick_launch">Using Quick >- Launch</a></q> for more information about using Quick Launch.</li> > <li class="unix"><strong>Use Preferences from System</strong>: Select this to > use the already set system preferences, overriding &brandShortName;' > ones. > > <p><strong>Note</strong>: This option is available only in XFT/GTK2 > builds.</p> > </li> Sorry, forgot to say that you should also remove the last paragraph (the XFT/GTK2 one) here.
Attachment #282895 - Flags: superreview?(neil) → superreview+
Addressed review comments from stefanh, carrying over r/sr.
Checked in by Standard8. I'll have to check if some other code is still influenced by Quick Launch, but that can be done in other bugs -> RESOLVED FIXED.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
I think this should be mentioned in the release notes for the shipment of SeaMonkey 2.0 to avoid new bugs like "turbo mode is missing / does not work".
(In reply to comment #18) > I think this should be mentioned in the release notes for the shipment of > SeaMonkey 2.0 to avoid new bugs like "turbo mode is missing / does not work". > Which can be duped to: Bug 383161 – keep in memory (turbo mode?) for faster startup not working
I really don't understand why turbo mode was removed. Seamonkey is slow again at startup. It was one of the few features that made me switch from Opera to Seamonkey. Nowadays, computers have plenty of RAM and preloading applications makes sense, as RAM is faster than HDDs. Is there a way to reimplement it and to disable it by default? This way everybody would be happy again.
(In reply to comment #20) > I really don't understand why turbo mode was removed. SeaMonkey has switched to a new toolkit, the old one supported turbo mode, the new one currently does not. The switch was required for many reasons that have already been posted elsewhere. The code that was left over, was removed by this bug as it was just "dead" code. > Is there a way to reimplement it and > to disable it by default? This way everybody would be happy again. See comment 1 for some suggestions. Currently though, no-one has volunteered to do or offered any patches for this feature.
You need to log in before you can comment on or make changes to this bug.