Closed
Bug 1482093
Opened 6 years ago
Closed 6 years ago
Make conversions from UTF-16 and Latin1 to UTF-8 utilize the slop in the first ASCII-sized allocation
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: hsivonen, Assigned: hsivonen)
References
Details
Attachments
(1 file)
After bug 1402247 and bug 1473337, if the code for converting to UTF-8 first guesses that the string contains ASCII, it tries to handle only ASCII first and reallocates if there is any non-ASCII. This happens even if the initial allocation had enough slop from rounding up to the nearest jemalloc bucket that a few non-ASCII codepoints would fit without reallocation. This bug is about making use of that available space.
|
Assignee | |
Comment 1•6 years ago
|
||
MozReview-Commit-ID: 4Y8K1JZkXWq
|
|
Assignee | |
Comment 2•6 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f30cd68b238738a0426afbd3b48f4e7e54ffb94a
|
||
Comment 3•6 years ago
|
||
Comment on attachment 8998837 [details] Bug 1482093 - Make conversions from UTF-16 and Latin1 to UTF-8 utilize the slop in the first ASCII-sized allocation. :Nika Layzell (PTO/OOT -> Aug. 20) has approved the revision.
Attachment #8998837 -
Flags: review+
Pushed by hsivonen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e35c67de74b1 Make conversions from UTF-16 and Latin1 to UTF-8 utilize the slop in the first ASCII-sized allocation. r=nika
|
||
Comment 5•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e35c67de74b1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•4 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•