1482190 - Custom top sites which match the search shortcut rules get incorrectly converted to search shortcuts after being added

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Kate Hudson :k88hudson]

STR:

With browser.newtabpage.activity-stream.improvesearch.topSiteSearchShortcuts.havePinned turned on, do the following:

1. Click the "Add Top Site" option of the top sites section menu. 
2. Add a title of "Custom Google" and the url "https://google.com/foo".

Expected:

A new regular pinned site with the title "Custom Google" and url "https://google.com/foo" should show up.

Actual:

A search shortcut shows up

Comment 1

[Kate Hudson :k88hudson]

Note that this also applies to editing sites in place.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4305

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/7f409d38dc66e6e692fd56358b5f74928e409b07
Fix Bug 1482190: don't convert manually pinned sites to search shortcuts (#4305)

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9

Comment 5

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" (63.0a1 - Build ID 20180813220525) installed and I can confirm that a "Top Site" that matches a search shortcut, is not converted automatically to one after being created.

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 7

[Cristian Fogel [:cfogel]]

Checked with 62.0b18 over Windows 10x64, macOS 10.12, Ubuntu 16.04LTS, and 62.0b19 on macOS10.12. 
The issue is not present on any OS.