Closed
Bug 1482240
Opened 6 years ago
Closed 3 years ago
[meta] ThreadResponsiveness uses nsITimer in a way which may disturb idleness checks
Categories
(Core :: Gecko Profiler, enhancement, P3)
Core
Gecko Profiler
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: smaug, Unassigned)
References
(Blocks 1 open bug)
Details
(Keywords: meta)
ThreadResponsiveness uses TYPE_ONE_SHOT timers. If such timer is about to run, idle runnables won't be processed.
*_LOW_PRIORITY timer might be better here
https://searchfox.org/mozilla-central/rev/0f4d50ff5211e8dd85e119ef683d04b63062ed90/xpcom/threads/nsITimer.idl#127-134
since that way profiler code would affect less how browser works.
It is still unclear to me what the number for "event processing delay" would mean in that case though. If there is idle time detected, it is perfectly ok to run something a bit longer.
Comment 1•6 years ago
|
||
Bug 1482244 is another way to approach this - it'll mean that we won't need to dispatch any runnables / timers at all in order to measure responsiveness.
Reporter | ||
Comment 2•6 years ago
|
||
I think we should tackle this in some way, either using different type of timer or the way bug 1482244 approaches the issue. We rely on idle queue when dealing with timers and also refresh driver uses idle queue occasionally (with timeout value). If raptor/tp6 profiles page loads with "Responsiveness" set on, it may not give accurate results.
Whiteboard: [qf]
Reporter | ||
Comment 3•6 years ago
|
||
rwood told that raptor/tp6 is profiled only once a day.
Reporter | ||
Updated•6 years ago
|
Whiteboard: [qf] → [qf:meta]
Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)
Updated•3 years ago
|
Updated•3 years ago
|
Summary: ThreadResponsiveness uses nsITimer in a way which may disturb idleness checks → [meta] ThreadResponsiveness uses nsITimer in a way which may disturb idleness checks
Updated•3 years ago
|
Performance Impact: ? → ---
Comment 5•3 years ago
|
||
smaug: The only dependency for this meta bug was closed as WONTFIX. Do we need to keep this open?
Flags: needinfo?(bugs)
Reporter | ||
Comment 6•3 years ago
|
||
I think this is indeed fixed now.
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(bugs)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•