1543147 - Disable 'Responsiveness' on profiler when creating profiles for raptor

Status: RESOLVED WONTFIX

(Testing :: Raptor, task, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1482240 'Responsiveness' calculations disturb idle detection. Could we disable that for now.

Comment 1

[Dave Hunt [:davehunt] [he/him] ⌚BST]

(In reply to Olli Pettay [:smaug] from comment #0)

Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1482240 'Responsiveness' calculations disturb idle detection. Could we disable that for now.

Could you provide details on how to disable these calculations? Also, when you say "for now" does that mean you'll ultimately want these to be re-enabled? Is there value in generating profiles for multiple configurations?

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Hopefully mstange could tell how to disable 'Responsiveness'. I know just the profiler UI, and there is a checkbox for responsiveness.
And with "for now" I mean, that until bug 1482240 is fixed in some way.
Right now I don't see much value using 'Responsiveness' during page load ever, since we've moved many
things to use idle queue, and 'Responsiveness' affects to idle detection.

(Responsiveness doesn't also detect input event queue handling, so it doesn't really measure responsiveness but something else)

Comment 3

[Robert Wood [:rwood]]

I'm guessing we would just remove 'responsiveness' from GeckoProfiler.start.features [0]

[0] https://searchfox.org/mozilla-central/rev/0376cbf447efa16922c550da3bfd783b916e35d3/testing/raptor/webext/raptor/runner.js#323

Comment 4

[Markus Stange [:mstange]]

That's right.

Comment 5

[Greg Mierzwinski [:sparky]]

Works in browsertime, it doesn't use responsiveness.