Closed Bug 1482256 Opened Last year Closed Last year

Add build option for switching to browser.xhtml

Categories

(Firefox :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: bdahl, Assigned: bdahl)

References

Details

Attachments

(1 file, 1 obsolete file)

Add something like 

> mk_add_options 'export MOZ_BROWSER_XHTML=1'

to enable loading the browser as xhtml.
Adds a new environment variable MOZ_BROWSER_XHTML to change Firefox to load
a modified version of browser.xul as browser.xhtml. Adds the xhtml
namespace to the script tags to make them work.

MozReview-Commit-ID: 2adtOVzXHKd
Attachment #8999005 - Flags: review?(dtownsend)
Adds a new environment variable MOZ_BROWSER_XHTML to change Firefox to load
a modified version of browser.xul as browser.xhtml. Adds the xhtml
namespace to the script tags to make them work.

MozReview-Commit-ID: 2adtOVzXHKd
Attachment #8999016 - Flags: review?(dtownsend)
Attachment #8999005 - Attachment is obsolete: true
Attachment #8999005 - Flags: review?(dtownsend)
I should note the browser loads with the above patch, but it is much better when bug 1479125 lands.
By the way, I've been doing try pushes for this with `./mach try -b do -p win64,linux64,macosx64 -u mochitests,xpcshell -t none --setenv MOZ_BROWSER_XHTML=1`. Obviously, there's a lot of orange still but since this is off by default that's fine. We should do a bug breakdown on problems once this lands.
Comment on attachment 8999016 [details] [diff] [review]
Support switching to browser.xul to browser.xhtml. r=

Review of attachment 8999016 [details] [diff] [review]:
-----------------------------------------------------------------

Yes but please get a bug on file for why we have to have those namespaces on the script tags.
Attachment #8999016 - Flags: review?(dtownsend) → review+
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9aae17d0e090
Support switching to browser.xul to browser.xhtml. r=mossop
Blocks: 1483034
Backed out changeset 9aae17d0e090 (bug 1482256) for browser-chrome failures on browser/base/content/test/static/browser_all_files_referenced.js. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=193769461&repo=mozilla-inbound&lineNumber=1381

 TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | there should be no unreferenced files - Got 1, expected 0
01:14:50     INFO - Stack trace:
01:14:50     INFO - chrome://mochikit/content/browser-test.js:test_is:1308
01:14:50     INFO - chrome://mochitests/content/browser/browser/base/content/test/static/browser_all_files_referenced.js:checkAllTheFiles:683
01:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1106
01:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1097
01:14:50     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:999
01:14:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
01:14:50     INFO - Not taking screenshot here: see the one that was previously logged
01:14:50     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_all_files_referenced.js | unreferenced file: chrome://browser/content/browser.xhtml - 

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=9aae17d0e0901fa1cccdf16b5f32d8212b2b84e2

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/397dbf4d571f60282bed90ce11918adfae99b0d1
Flags: needinfo?(bdahl)
Pushed by bdahl@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6639ad4e8e86
Support switching to browser.xul to browser.xhtml. r=mossop
Flags: needinfo?(bdahl)
https://hg.mozilla.org/mozilla-central/rev/6639ad4e8e86
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
See Also: → 1502556
You need to log in before you can comment on or make changes to this bug.