Closed
Bug 1482272
Opened 7 years ago
Closed 7 years ago
Don't set -DEBUG twice on Windows links
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: away, Assigned: away)
References
Details
Attachments
(1 file)
|
3.07 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
We already get `-DEBUG` from MOZ_DEBUG_LDFLAGS.
We already append MOZ_DEBUG_LDFLAGS when MOZ_DEBUG_SYMBOLS is set.
Assignee: nobody → dmajor
Attachment #8999022 -
Flags: review?(ted)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8999022 [details] [diff] [review]
Don't set -DEBUG twice on Windows links
Review of attachment 8999022 [details] [diff] [review]:
-----------------------------------------------------------------
Huh, funny. I guess this must have been translated from some code in {config,rules}.mk and so the existing weird behavior was preserved.
Attachment #8999022 -
Flags: review?(ted) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cff9d154758
Don't set -DEBUG twice on Windows links. r=ted
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•