Closed Bug 1482272 Opened 2 years ago Closed Last year

Don't set -DEBUG twice on Windows links

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dmajor, Assigned: dmajor)

References

Details

Attachments

(1 file)

We already get `-DEBUG` from MOZ_DEBUG_LDFLAGS.
We already append MOZ_DEBUG_LDFLAGS when MOZ_DEBUG_SYMBOLS is set.
Assignee: nobody → dmajor
Attachment #8999022 - Flags: review?(ted)
Comment on attachment 8999022 [details] [diff] [review]
Don't set -DEBUG twice on Windows links

Review of attachment 8999022 [details] [diff] [review]:
-----------------------------------------------------------------

Huh, funny. I guess this must have been translated from some code in {config,rules}.mk and so the existing weird behavior was preserved.
Attachment #8999022 - Flags: review?(ted) → review+
Pushed by dmajor@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cff9d154758
Don't set -DEBUG twice on Windows links. r=ted
https://hg.mozilla.org/mozilla-central/rev/4cff9d154758
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.