Closed Bug 1482516 Opened Last year Closed Last year

Ensure we touch the build backend output list file when re-building the build backend

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: cmanchester, Assigned: cmanchester)

References

Details

Attachments

(1 file)

Bug 1478798 hits an issue with our logic for touching/updating the backend output list: because the current check things the created file count indicates the list has been updated, if we have situation where a backend output file has been removed and re-created but the list hasn't otherwise changed, we'll end up using a FileAvoidWrite and bypassing the additional mtime bump in bug 1216901.

It looks like we should just be comparing the file sets to detect this instead.
Assignee: nobody → cmanchester
If a backend output file is deleted outside of the build system the non-zero
"created" count can make the current check erroneously think the list of
outputs has changed.
Comment on attachment 8999287 [details]
Bug 1482516 - Use set comparison to determine whether the list of build backend outputs has changed.

Gregory Szorc [:gps] has approved the revision.
Attachment #8999287 - Flags: review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ebe78e2810c5
Use set comparison to determine whether the list of build backend outputs has changed. r=gps,firefox-build-system-reviewers
https://hg.mozilla.org/mozilla-central/rev/ebe78e2810c5
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.