1482565 - Support and show @Яндекс and @百度 searches for yandex and baidu

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Ed Lee :Mardak]

For yandex and baidu, bug 1482125 added the @keyword and bug 1481901 added the tile. Both places need to be updated to use the not-english keyword.

Comment 1

[Ed Lee :Mardak]

Attachment: address bar keywords

Comment 2

[Ed Lee :Mardak]

Attachment: activity stream tiles

Comment 3

[Ed Lee :Mardak]

Attachment: Bug 1482565 - Support and show @Яндекс and @百度 searches for yandex and baidu

Depends on D3133
Depends on D3033

Comment 4

[Ed Lee :Mardak]

mkaply, originally I was thinking activity stream would check Services.search.getDefaultEngines().…._internalAliases but then figured activity stream probably shouldn't load the search service too early unnecessarily, so ended up duplicating the array, but then looks like bug 1482579 is saying it's too early anyway.

Ideally we get rid of this duplication, but we also don't want to impact startup or cause things to be loaded too early unnecessarily.

Comment 5

[Mike Kaply [:mkaply]]

Comment on attachment 8999318 [details]
Bug 1482565 - Support and show @Яндекс and @百度 searches for yandex and baidu

Mike Kaply [:mkaply] has approved the revision.

Comment 6

[Mike Kaply [:mkaply]]

Yeah, I noticed that error when this first started landing.

I don't think there's going to be anything we can do to avoid an sync load of the search service because of how early Activity stream needs the information.

We're putting information that we need from the search service on the very first tab...

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1631a0ca4db
Support and show @Яндекс and @百度 searches for yandex and baidu r=mkaply

Comment 8

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e1631a0ca4db

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4329

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4190e3b81c06aaa71082c5016159749f80f266d0
chore(mc): Port Bug 1482565 - Support and show @Яндекс and @百度 searches for yandex and baidu r=mkaply (#4329)

Comment 11

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/30ff3056bd2716761f7908e5fa38c14c7952adb8

Comment 12

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 13

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) and Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64. @Яндекс and @百度 searches are shown for Yandex and Baidu.