1482125 - Add internal aliases for common search plugins

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

Like bug 1480504 but for all packaged ones to allow for bug 1480507.

There's an open question to what the alias should be for non-english search providers, e.g., use the name or just the "english" domain for the @alias.

We could support multiple although that then just shifts the question to what shows up on the tile in activity stream, as that's what users will see as the "suggested way"

Comment 1

[Ed Lee :Mardak]

Here's a bunch of search plugins and their name vs domain:

https://searchfox.org/mozilla-central/search?q=searchform%7Cshortname&regexp=true&path=browser%2Fcomponents%2Fsearch%2Fsearchplugins

mkaply, are these the ones we should be looking at?

Aaron, how do we pick the keyword for even just the packaged search engines from that list?

E.g.,
<ShortName>亚马逊</ShortName>
<SearchForm>https://www.amazon.cn/</SearchForm>

Chinese users might not be typing "amazon" normally as it might be more difficult to type than "亚马逊"

Comment 2

[Mike Kaply [:mkaply]]

I thought the whole point of this was to be kind of an experiment at first?

We have a hundred+ of these and not all of them merit being a first class search in the URL bar.

And many of them are non US, so the shortcut we pick might not be the one we expect.

Comment 3

[Mike Kaply [:mkaply]]

So I'm going to implement this in the search service. Here is my initial list of mappings of providers to engnies that we are going to include:

const ENGINE_ALIASES = new Map([
  ["Google", "@google"],
  ["Amazon", "@amazon"],
  ["Twitter", "@twitter"],
  ["Wikipedia", "@wikipedia"],
  ["eBay", "@ebay"],
  ["Bing", "@bing"],
  ["DuckDuckGo", "@duckduckgo"],
  ["Yandex", "@yandex"],
  ["Яндекс", "@yandex"],
  ["百度", "@baidu"],
]);

Wikipedia is going to be a little more work, but I already have this basically working.

Comment 4

[Mike Kaply [:mkaply]]

Attachment: Bug 1482125 - Add internal aliases for common search plugins.

Comment 7

[Ed Lee :Mardak]

Comment on attachment 8998923 [details]
Bug 1482125 - Add internal aliases for common search plugins.

Ed Lee :Mardak has approved the revision.

Comment 8

[Drew Willcoxon :adw]

Comment on attachment 8998923 [details]
Bug 1482125 - Add internal aliases for common search plugins.

Drew Willcoxon :adw has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f187635f2e4
Add internal aliases for common search plugins. r=Mardak,adw

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out changeset 1f187635f2e4 (Bug 1482125) for test_nsDefaultURIFixup_search.js failures.

Push with failures:https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1f187635f2e4b801134bd6b549a55df5e3ed96c7

Backout link: https://hg.mozilla.org/integration/autoland/rev/c5109843829d5758ac7e5ad618b826141396ad59

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=193321246&repo=autoland&lineNumber=2058

[task 2018-08-10T17:06:38.005Z] 17:06:38     INFO -  TEST-START | docshell/test/unit/test_nsDefaultURIFixup_search.js
[task 2018-08-10T17:06:38.653Z] 17:06:38  WARNING -  TEST-UNEXPECTED-FAIL | docshell/test/unit/test_nsDefaultURIFixup_search.js | xpcshell return code: 0
[task 2018-08-10T17:06:38.654Z] 17:06:38     INFO -  TEST-INFO took 646ms

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/53bdfc04ee13
Add internal aliases for common search plugins. r=Mardak,adw

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/53bdfc04ee13

Comment 13

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/33bcb1046cd196cdffa41363f4b0d04d2c8b175b