Status

()

enhancement
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: jya, Assigned: jya)

Tracking

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

10 months ago
We're supposed to support opus in mp4, but those files can't possibly play.

The Opus decoder expect to find data in mCodecSpecificConfig
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/platforms/agnostic/OpusDecoder.cpp#70

The data found there must be 19 bytes long minimum:
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/ogg/OpusParser.cpp#41

However the data generated by the MP4 demuxer is only 8 bytes long ever
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/mp4/DecoderData.cpp#81

As such, decoding the Opus codec header will always fail when opus is found in a MP4 container..

I thought we had mochitest to check those files...
Assignee

Updated

10 months ago
Assignee: nobody → jyavenard
Assignee

Updated

10 months ago
Depends on: 1482605
Comment on attachment 8999743 [details]
Bug 1482841 - P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r?padenot

Paul Adenot (:padenot) has approved the revision.
Attachment #8999743 - Flags: review+
Blocks: 1358024
Comment on attachment 8999698 [details]
Bug 1482841 - P2. Fix opus in mp4 decoding. r?padenot

Paul Adenot (:padenot) has approved the revision.
Attachment #8999698 - Flags: review+

Comment 5

10 months ago
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1366d8fa15
P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/53d249277299
P2. Fix opus in mp4 decoding. r=padenot

Comment 6

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7b1366d8fa15
https://hg.mozilla.org/mozilla-central/rev/53d249277299
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.