Closed Bug 1482841 Opened 5 years ago Closed 5 years ago

Opus in MP4 do not play

Categories

(Core :: Audio/Video: Playback, enhancement)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(2 files)

Bug 1482841 - P2. Fix opus in mp4 decoding. r?padenot
46 bytes, text/x-phabricator-request
padenot
: review+
Details | Review
Bug 1482841 - P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r?padenot
46 bytes, text/x-phabricator-request
padenot
: review+
Details | Review 
We're supposed to support opus in mp4, but those files can't possibly play.

The Opus decoder expect to find data in mCodecSpecificConfig
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/platforms/agnostic/OpusDecoder.cpp#70

The data found there must be 19 bytes long minimum:
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/ogg/OpusParser.cpp#41

However the data generated by the MP4 demuxer is only 8 bytes long ever
https://searchfox.org/mozilla-central/rev/ca869724246f4230b272ed1c8b9944596e80d920/dom/media/mp4/DecoderData.cpp#81

As such, decoding the Opus codec header will always fail when opus is found in a MP4 container..

I thought we had mochitest to check those files...
Assignee: nobody → jyavenard
Depends on: 1482605
Comment on attachment 8999743 [details]
Bug 1482841 - P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r?padenot

Paul Adenot (:padenot) has approved the revision.
Attachment #8999743 - Flags: review+
Comment on attachment 8999698 [details]
Bug 1482841 - P2. Fix opus in mp4 decoding. r?padenot

Paul Adenot (:padenot) has approved the revision.
Attachment #8999698 - Flags: review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b1366d8fa15
P1. Update mp4parse-rust to 643f48e137592e6318f6c780448374324908da31. r=padenot
https://hg.mozilla.org/integration/mozilla-inbound/rev/53d249277299
P2. Fix opus in mp4 decoding. r=padenot
https://hg.mozilla.org/mozilla-central/rev/7b1366d8fa15
https://hg.mozilla.org/mozilla-central/rev/53d249277299
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.