Closed Bug 1482605 Opened 6 years ago Closed 6 years ago

Add preliminary support for Opus channel mapping version 2

Categories

(Core :: Audio/Video: Playback, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jya, Assigned: jya)

References

Details

Attachments

(1 file)

As per https://tools.ietf.org/html/draft-ietf-codec-ambisonics-08

"From a technical perspective, the only change required here is that the media parser should not fail when seeing channel mapping = 2, which I think is what's currently breaking media playback for these formats. (To reproduce, open youtu.be/WqCH4DNQBUA in FF with Chrome's useragent override, otherwise we serve AAC to FF)  
"

so this change is to only allow decoding those streams without producing errors. Channels order would be left unchanged.
We do not perform any channels placement, instead we leave the channels in the order they come in.
Comment on attachment 8999392 [details]
Bug 1482605 - Don't error on Opus channel mapping version 2. r?padenot

Paul Adenot (:padenot) has approved the revision.
Attachment #8999392 - Flags: review+
Assignee: nobody → jyavenard
Blocks: 1482841
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0dcc490db922
Don't error on Opus channel mapping version 2. r=padenot
https://hg.mozilla.org/mozilla-central/rev/0dcc490db922
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1502488
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: