Closed Bug 1482866 Opened Last year Closed Last year
Array now that it doesn't store kids .
Now that children don't need to be stored, this may be simpler.
No need for void* stuff, but I had to keep the semi-manual memory management to allocate everything inline as we currently do.
Comment on attachment 8999642 [details] Simplify AttrArray's implementation. r=smaug Olli Pettay [:smaug] has approved the revision.
Attachment #8999642 - Flags: review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/cba97273eb10 Simplify AttrArray's implementation. r=smaug
https://hg.mozilla.org/mozilla-central/rev/cba97273eb10#l2.178 This doesn't compile in MSVS C++: + // Allocated in the same buffer as `Impl`. + InternalAttr mBuffer; 1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): error C2220: warning treated as error - no 'object' file generated 1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): warning C4200: nonstandard extension used: zero-sized array in struct/union 1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): note: This member will be ignored by a defaulted constructor or copy/move assignment operator
I'll follow up in bug 1483818.
You need to log in before you can comment on or make changes to this bug.