Closed Bug 1482866 Opened Last year Closed Last year

Simplify AttrArray now that it doesn't store kids.

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

Now that children don't need to be stored, this may be simpler.
Priority: -- → P3
No need for void* stuff, but I had to keep the semi-manual memory
management to allocate everything inline as we currently do.
Comment on attachment 8999642 [details]
Simplify AttrArray's implementation. r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #8999642 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cba97273eb10
Simplify AttrArray's implementation. r=smaug
https://hg.mozilla.org/mozilla-central/rev/cba97273eb10
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
https://hg.mozilla.org/mozilla-central/rev/cba97273eb10#l2.178
This doesn't compile in MSVS C++:
+    // Allocated in the same buffer as `Impl`.
+    InternalAttr mBuffer[0];

1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): error C2220: warning treated as error - no 'object' file generated
1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): warning C4200: nonstandard extension used: zero-sized array in struct/union
1:42.90 c:\mozilla-source\comm-central\dom\base\AttrArray.h(214): note: This member will be ignored by a defaulted constructor or copy/move assignment operator
Flags: needinfo?(emilio)
Depends on: 1483818
I'll follow up in bug 1483818.
Flags: needinfo?(emilio)
Blocks: 1483964
See Also: → 1483981
You need to log in before you can comment on or make changes to this bug.