Closed Bug 1482868 Opened 6 years ago Closed 6 years ago

[remote-dbg-next] Show network locations in the Sidebar

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(5 files, 2 obsolete files)

Bug 1482868 - Move aboutdebugging sidebar components to dedicated folder;r=daisuke
46 bytes, text/x-phabricator-request
daisuke
: review+
Details | Review
Bug 1482868 - Prevent empty values only when submitting network location;r=daisuke
46 bytes, text/x-phabricator-request
daisuke
: review+
Details | Review
Bug 1482868 - Rename connect-network-icon to globe icon;r=daisuke
46 bytes, text/x-phabricator-request
daisuke
: review+
Details | Review
Bug 1482868 - Show network locations as non selectable sidebar items;r=daisuke,ladybenko
46 bytes, text/x-phabricator-request
daisuke
: review+
ladybenko
: review+
Details | Review
Bug 1482868 - Show no devices... message when devices list empty;r=daisuke,ladybenko
46 bytes, text/x-phabricator-request
daisuke
: review+
ladybenko
: review+
Details | Review
The goal of this bug is to list the available network locations in the sidebar. Connecting to the device is _NOT_ in scope for this bug and should be in a followup. We might have some logic to show/hide unavailable locations? Or show them differently?
Depends on D3229
Attachment #8999666 - Attachment description: Bug 1482868 - Move aboutdebugging sidebar components to dedicated folder → Bug 1482868 - Move aboutdebugging sidebar components to dedicated folder;r=daisuke
Attachment #8999668 - Attachment description: Bug 1482868 - Prevent empty values only when submitting network location → Bug 1482868 - Prevent empty values only when submitting network location;r=daisuke
Attachment #8999672 - Attachment description: Bug 1482868 - Rename connect-network-icon to globe icon → Bug 1482868 - Rename connect-network-icon to globe icon;r=daisuke
Comment on attachment 8999666 [details] Bug 1482868 - Move aboutdebugging sidebar components to dedicated folder;r=daisuke Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999666 - Flags: review+
Attachment #8999673 - Attachment description: Bug 1482868 - Show network locations as non selectable sidebar items → Bug 1482868 - Show network locations as non selectable sidebar items;r=daisuke,ladybenko
Attachment #8999677 - Attachment description: Bug 1482868 - Show no devices... message when devices list empty → Bug 1482868 - Show no devices... message when devices list empty;r=daisuke,ladybenko
Comment on attachment 8999668 [details] Bug 1482868 - Prevent empty values only when submitting network location;r=daisuke Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999668 - Flags: review+
Comment on attachment 8999672 [details] Bug 1482868 - Rename connect-network-icon to globe icon;r=daisuke Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999672 - Flags: review+
Comment on attachment 8999673 [details] Bug 1482868 - Show network locations as non selectable sidebar items;r=daisuke,ladybenko Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999673 - Flags: review+
Comment on attachment 8999677 [details] Bug 1482868 - Show no devices... message when devices list empty;r=daisuke,ladybenko Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #8999677 - Flags: review+
Blocks: 1483497
Attachment #8999678 - Attachment is obsolete: true
Attachment #8999679 - Attachment is obsolete: true
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P3
Comment on attachment 8999677 [details] Bug 1482868 - Show no devices... message when devices list empty;r=daisuke,ladybenko Belén [:ladybenko] has approved the revision.
Attachment #8999677 - Flags: review+
Comment on attachment 8999673 [details] Bug 1482868 - Show network locations as non selectable sidebar items;r=daisuke,ladybenko Belén [:ladybenko] has approved the revision.
Attachment #8999673 - Flags: review+
Blocks: 1486787
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e417158d9456 Move aboutdebugging sidebar components to dedicated folder;r=daisuke
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/40fb4831d16c Prevent empty values only when submitting network location;r=daisuke
https://hg.mozilla.org/mozilla-central/rev/e417158d9456 https://hg.mozilla.org/mozilla-central/rev/40fb4831d16c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3273afbe891 Rename connect-network-icon to globe icon;r=daisuke
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4e4416a2bd7f Show network locations as non selectable sidebar items;r=daisuke,ladybenko
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bc01243454d Show no devices... message when devices list empty;r=daisuke,ladybenko
Sorry for the sporadic landing, but autoland intermittently closed when I was trying to land this yesterday :( Only managed to get 2 patches through, and then did the rest this morning.
Priority: P3 → P1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: