1482875 - Add a test for pasting with middle-click in the console input

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[Rob Wu [:robwu]]

STR:
1. Open the console.
2. Switch to the console tab.
3. Select any text.
4. Click using your mouse wheel in the editable area.

Expected:
- The selected text should be pasted.

Actual:
- Nothing is pasted

This is a regression caused by bug 1470922.
mozregression result: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6cdfa85af851cd124cd535dacd0ce8e4131aeec5&tochange=d01677a667bc35ccd45af746d035d3daa97571ba


Another bug is that selecting text does not put the selected text on the primary keyboard (just like bug 1200448).

When I revert devtools.webconsole.jsterm.codeMirror back to false, then these bugs disappear.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

It does look like Bug 953389, since we use CodeMirror in the input now (like in the StyleEditor and Debugger).

Comment 2

[David Durst [:ddurst]]

Are you taking this? (notes that soft freeze is next week)

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to David Durst [:ddurst] (REO for 63) from comment #2)
> Are you taking this? (notes that soft freeze is next week)

The CodeMirror input is going to stay nightly-only for 63, so this won't ride the train to beta. I'll leave the ni? open to make sure it gets tracked before riding the train.

Comment 4

[David Durst [:ddurst]]

(re-adding the leave-open NI, moved to bgrins)

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to David Durst [:ddurst] (REO for 63) from comment #4)
> (re-adding the leave-open NI, moved to bgrins)

It seems this is being handled in Bug 953389. We can leave this bug open for tracking / verification. As this is nightly only I don't think it needs to be tracked on 63.

Comment 6

[Florens Verschelde :fvsch]

Attachment: console paste area

Works for me on Fedora 28, latest Firefox Nightly, with the new jsterm enabled (default config).

Only tiny issue is that it won't work if clicking outside the green area (in the attached screenshot), but I don't think that would be a real problem for too many users.

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Since it looks like it's working now, let's repurpose this bug to add a test that cover this functionality.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1482875 - Monkeypatch CodeMirror to handle pasting with middle-click in DevTools; r=gl.

Instead of focusing the input when a paste event is fired
on the scroller (which does not work on Firefox), we
dispatch the `paste` event from the scroller to the textarea.

We take this as an opportunity to update the package.json (we
probably don't need babel here, and we can update to latest
webpack).

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1482875 - Add test for middle-click pasting in console input; r=Honza.

Depends on D16792

Comment 10

[Gabriel Luong [:gl] (ΦωΦ)]

Have we also consider filing a bug on CodeMirror so it can be fixed upstream?

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Gabriel [:gl] (ΦωΦ) from comment #10)

Have we also consider filing a bug on CodeMirror so it can be fixed upstream?

Yes, https://github.com/codemirror/CodeMirror/pull/5751

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9915f978e03b
Monkeypatch CodeMirror to handle pasting with middle-click in DevTools; r=gl.
https://hg.mozilla.org/integration/autoland/rev/bf190444c579
Add test for middle-click pasting in console input; r=Honza.

Comment 13

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9915f978e03b
https://hg.mozilla.org/mozilla-central/rev/bf190444c579