1483065 - Add UT events for SEARCH_EDIT_ADD and SEARCH_EDIT_DELETE

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Comment 1

[Nan Jiang [:nanj]]

Attachment: Summary: Fix Bug 1483065 - Add UT events for SEARCH_EDIT_ADD and SEARCH_EDIT_DELETE

Comment 2

[Nan Jiang [:nanj]]

Attachment: Bug 1483065 - Add search edit UT events for activity stream

Comment 3

[Ursula Sarracini (:ursula)]

Comment on attachment 8999925 [details]
Bug 1483065 - Add search edit UT events for activity stream

Ursula Sarracini (:ursula) has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98d17facfe00
Add search edit UT events for activity stream r=ursula

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/98d17facfe00

Comment 6

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/175ad1c7206e3947b2b7ea751b4b2599807cd6bd

Comment 7

[Chris H-C :chutten]

Did this and the other new data collection patches receive Data Collection Review[1]? Top Search's bug tree's so big it might be in there somewhere and I just missed it :S

[1]: https://wiki.mozilla.org/Firefox/Data_Collection

Comment 8

[Ed Lee :Mardak]

(In reply to Chris H-C :chutten from comment #7)
> Did this and the other new data collection patches receive Data Collection Review[1]?
I believe that was done in bug 1480513 comment 5 and bug 1483297 comment 3.

Code and documentation updated in:

https://github.com/mozilla/activity-stream/pull/4290
https://github.com/mozilla/activity-stream/pull/4336
https://github.com/mozilla/activity-stream/pull/4340

Comment 9

[Chris H-C :chutten]

Oh good, thank you!

Comment 10

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible in the latest Nightly (63.0a1, Build ID 20180816100035) and Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64. The pings are sent when the user adds and when they remove a search shortcut.