Closed Bug 1483156 Opened 6 years ago Closed 6 years ago

Perma TV dom/payments/test/test_currency_amount_validation.html | Currency of PaymentItem total should be 'USD', but got BOB.

Categories

(Core :: DOM: Web Payments, defect, P1)

Product:
Core
Component:
DOM: Web Payments
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: marcosc)

Details

(Keywords: intermittent-failure, Whiteboard: [webpayments-reserve])

Attachments

(1 file, 1 obsolete file)

Fixed nit
22.24 KB, patch
Details | Diff | Splinter Review 
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=193801954&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/fAXLINAGTbCP1uduWoUWkw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-08-14T06:22:39.311Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected 'TypeError', but got 'TypeError' 
[task 2018-08-14T06:22:39.312Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected 'TypeError', but got 'TypeError' 
[task 2018-08-14T06:22:39.312Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | PaymentRequest should be created 
[task 2018-08-14T06:22:39.313Z] 06:22:39     INFO - Buffered messages finished
[task 2018-08-14T06:22:39.319Z] 06:22:39     INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_currency_amount_validation.html | Currency of PaymentItem total should be 'USD', but got BOB. 
[task 2018-08-14T06:22:39.319Z] 06:22:39     INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:21:5
[task 2018-08-14T06:22:39.319Z] 06:22:39     INFO - Async*@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:18:17
[task 2018-08-14T06:22:39.319Z] 06:22:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-08-14T06:22:39.319Z] 06:22:39     INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_currency_amount_validation.html | Currency of PaymentItem total should be 'USD', but got EUR. 
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:21:5
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - Async*@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:18:17
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_currency_amount_validation.html | Currency of PaymentItem total should be 'USD', but got XDR. 
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:21:5
[task 2018-08-14T06:22:39.320Z] 06:22:39     INFO - Async*@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:18:17
[task 2018-08-14T06:22:39.321Z] 06:22:39     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-08-14T06:22:39.323Z] 06:22:39     INFO - TEST-UNEXPECTED-FAIL | dom/payments/test/test_currency_amount_validation.html | Currency of PaymentItem total should be 'USD', but got XTS. 
[task 2018-08-14T06:22:39.323Z] 06:22:39     INFO - testFailHandler@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:21:5
[task 2018-08-14T06:22:39.324Z] 06:22:39     INFO - Async*@https://example.com/tests/dom/payments/test/test_currency_amount_validation.html:18:17
[task 2018-08-14T06:22:39.326Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.328Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.328Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.329Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.334Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.334Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.334Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.334Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.334Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.335Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.336Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.336Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Expected rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.337Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Should be rejected with 'TypeError', but got TypeError. 
[task 2018-08-14T06:22:39.339Z] 06:22:39     INFO - TEST-PASS | dom/payments/test/test_currency_amount_validation.html | Should be rejected with 'RangeError', but got RangeError. 
[task 2018-08-14T06:22:39.339Z] 06:22:39     INFO - GECKO(3780) | MEMORY STAT | vsize 1476MB | residentFast 123MB | heapAllocated 20MB
[task 2018-08-14T06:22:39.340Z] 06:22:39     INFO - TEST-OK | dom/payments/test/test_currency_amount_validation.html | took 101ms
Appeared when landing  Bug 1408234.
Attached patch Refactor test (obsolete) — — Splinter Review 
I was able to reproduce this, so I made this a bit less racy. There were a few Promise related issues - where things could have gotten out of sync. 

There were also a few functions that could have stayed sync, so I refactored those too.
Attachment #9002656 - Flags: review?(echuang)
Assignee: nobody → mcaceres
Priority: P5 → P3
Whiteboard: [webpayments][triage]
Comment on attachment 9002656 [details] [diff] [review]
Refactor test

Review of attachment 9002656 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/payments/test/test_currency_amount_validation.html
@@ +351,4 @@
>  <body>
>  <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1367669">Mozilla Bug 1367669</a>
>  <a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1388661">Mozilla Bug 1388661</a>
> +

nit: no new line at end of file
Attachment #9002656 - Flags: review?(echuang) → review+
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: P3 → P1
Whiteboard: [webpayments][triage] → [webpayments-reserve]
Attached patch Fixed nit — — Splinter Review 
Fixed nit, carrying over r+
Attachment #9002656 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/809610242278
Currency of PaymentItem total should be 'USD', but got BOB r=edenchuang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/809610242278
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: