Closed
Bug 1483169
Opened 6 years ago
Closed 6 years ago
Output argument index when compartment checks fail
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
References
Details
Attachments
(1 file)
|
11.14 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
At the moment our compartment checks print the addresses of the compartments that mismatch, but don't indicate which argument to assertSameCompartment() was found to be at fault.
|
Assignee | |
Comment 1•6 years ago
|
||
Patch to add argument index to compartment check failure message. I also changed this to use MOZ_CRASH_UNSAFE_PRINTF which should mean the message ends up in crash-stats.
Attachment #8999878 -
Flags: review?(jdemooij)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8999878 [details] [diff] [review] bug1481844-compartment-checks Review of attachment 8999878 [details] [diff] [review]: ----------------------------------------------------------------- Nice
Attachment #8999878 -
Flags: review?(jdemooij) → review+
Pushed by jcoppeard@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5660b9d6ef1e Output argument index when compartment checks fail r=jandem
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5660b9d6ef1e
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•