1483169 - Output argument index when compartment checks fail

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco) (PTO until 10th March)]

At the moment our compartment checks print the addresses of the compartments that mismatch, but don't indicate which argument to assertSameCompartment() was found to be at fault.

Comment 1

[Jon Coppeard (:jonco) (PTO until 10th March)]

Attachment: bug1481844-compartment-checks

Patch to add argument index to compartment check failure message.

I also changed this to use MOZ_CRASH_UNSAFE_PRINTF which should mean the message ends up in crash-stats.

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8999878 [details] [diff] [review]
bug1481844-compartment-checks

Review of attachment 8999878 [details] [diff] [review]:
-----------------------------------------------------------------

Nice

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5660b9d6ef1e
Output argument index when compartment checks fail r=jandem

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5660b9d6ef1e