1483804 - Perma bustage at js/src/vm/JSContext-inl.h:187:5: error: 'CompartmentChecker' was not declared in this scope when Gecko 63 merges to Beta on 2018-08-27

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&revision=24dc4e9ee792e773a89b065468147ec766612347&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=194147773&repo=try

https://hg.mozilla.org/mozilla-central/file/5660b9d6ef1e/js/src/vm/JSContext-inl.h#l178 and below

Comment 1

[Jon Coppeard (:jonco) (PTO until 10th March)]

Attachment: bug1483804-compartment-checker

I didn't spot that there was releaseAssertSameCompartment() which uses CompartmentChecker even if JS_CRASH_DIAGNOSTICS is not defined.

Comment 2

[Andreea Pavel [:apavel]]

Importing the above mentioned attachment cleared the most recent beta sim of this failure: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d921b66fcc8346d2fc64cdd3b0f9738f509c2c8&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=runnable

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/190e8fd11756
Fix releaseAssertSameCompartment bustage when this merges to beta r=jandem

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/190e8fd11756

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Verified fixed with today's beta simulations: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f4ed8f51c6fbd9cd89558f7ad7a3cc80a261752&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

No need to track this for 63.