1483274 - Fold nsIRemoteBrowser into nsIBrowser

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P3)

Description

[Brian Grinstead [:bgrins]]

Currently in XBL we have `browser` (which implements nsIBrowser) and `remote-browser` (which implements both nsIBrowser and nsIRemoteBrowser). We then dynamically switch which XBL binding is attached to a browser tag at runtime in the tabbrowser based on whether the tab should be remote or not.

Custom Elements don't have the capability to switch which element is applied at runtime (since the definition is keyed on tag name). This means we'll likely want to support both the remote and non-remote implementation in one element definition, so having a single interface to implement will make that possible.

I think this looks like:

1) Fold in the 2 properties from nsIRemoteBrowser into nsIBrowser
2) Expose `readonly attribute boolean isRemoteBrowser` which calls into the JS impl
3) Update the 2 callers that Qi into nsIRemoteBrowser to Qi to nsIBrowser and then check `isRemoteBrowser`

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1483274 - Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug

Update Qi calls for nsIRemoteBrowser to instead check isRemoteBrowser.
This will allow a single element definition for both remote and non-remote
browsers.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8999979 [details]
Bug 1483274 - Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug

Setting review flag in bugzilla since the dashboard seems to have lost the phab review.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8999979 [details]
Bug 1483274 - Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92832d7ecc29
Remove nsIRemoteBrowser and always use nsIBrowser;r=smaug

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/92832d7ecc29