Closed Bug 1492967 Opened 3 years ago Closed 3 years ago

Merge together remote-browser and browser bindings

Categories

(Toolkit :: XUL Widgets, task, P3)

Product:
Toolkit
Component:
XUL Widgets
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1492967 - Merge together remote-browser and browser bindings;r=mconley,r=ochameau
46 bytes, text/x-phabricator-request
mconley
: review+
ochameau
: review+
Details | Review 
This is something I believe we'll need to do for Custom Elements since we can't swap an element from one Custom Element to another in the same way we can with XBL.

This will let us remove some duplicated code like https://searchfox.org/mozilla-central/rev/0b8ed772d24605d7cb44c1af6d59e4ca023bd5f5/toolkit/content/widgets/browser.xml#870-874.

There's a bit of an odd case to take care with where we bind the 'browser' binding to a [remote=true] browser when it has the 'lightweight' class in reftests (https://searchfox.org/mozilla-central/rev/94e37e71ffbfd39e6ad73ebcda5d77cce8d341ae/toolkit/content/xul.css#188 / https://searchfox.org/mozilla-central/rev/0b8ed772d24605d7cb44c1af6d59e4ca023bd5f5/layout/tools/reftest/reftest.jsm#181). This means we return true for `isRemoteBrowser` but apply the non-remote browser binding which runs through different code paths.
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Priority: -- → P3
Attachment #9010842 - Attachment description: Bug 1492967 - Merge together remote-browser and browser bindings → Bug 1492967 - Merge together remote-browser and browser bindings;r=mconley,r=ochameau
Try looks fine, and not seeing any change on talos with the patch applied
Comment on attachment 9010842 [details]
Bug 1492967 - Merge together remote-browser and browser bindings;r=mconley,r=ochameau

Mike Conley (:mconley) (:⚙️) has approved the revision.
Attachment #9010842 - Flags: review+
Comment on attachment 9010842 [details]
Bug 1492967 - Merge together remote-browser and browser bindings;r=mconley,r=ochameau

Alexandre Poirot [:ochameau] has approved the revision.
Attachment #9010842 - Flags: review+
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/95d82d6b1751
Merge together remote-browser and browser bindings;r=ochameau,mconley
https://hg.mozilla.org/mozilla-central/rev/95d82d6b1751
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Component: XUL → XUL Widgets
Product: Core → Toolkit
Depends on: 1514757
Blocks: 1518282
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.