Closed
Bug 1483403
Opened 6 years ago
Closed 6 years ago
remove calls to nsICertificateDialogs.viewCert and invoke UI directly
Categories
(MailNews Core :: General, defect)
MailNews Core
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 63.0
People
(Reporter: dipen, Assigned: jorgk-bmo)
Details
Attachments
(1 file)
|
2.58 KB,
patch
|
dipen
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0 Build ID: 20180704003137 Steps to reproduce: The Core Security::PSM interface nsICertificateDialogs.viewCert has been removed. Update calls to invoke the UI directly. See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1468225
|
Assignee | |
Comment 1•6 years ago
|
||
Thanks for the heads-up, we have two calls: mailnews/extensions/smime/content/msgCompSecurityInfo.js 221 cd.viewCert(parent, cert); mailnews/extensions/smime/content/msgReadSecurityInfo.js 212 cd.viewCert(parent, cert);
|
|
Assignee | |
Comment 2•6 years ago
|
||
Dipen, could you kindly review this. We can land this before bug 1468225 lands, right?
Assignee: nobody → jorgk
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Attachment #9001528 -
Flags: review?(bugzilla)
|
Reporter | |
Comment 3•6 years ago
|
||
Comment on attachment 9001528 [details] [diff] [review] 1483403-viewCert.patch The changes are consistent with those going in https://bugzilla.mozilla.org/show_bug.cgi?id=1468225 Looks good to me.
Attachment #9001528 -
Flags: review?(bugzilla) → review+
|
|
Reporter | |
Comment 4•6 years ago
|
||
Yes it can land before https://bugzilla.mozilla.org/show_bug.cgi?id=1468225
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/222b53600d4c Port bug 1468225: replace use of nsICertificateDialogs.viewCert. r=dipen DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 6•6 years ago
|
||
Thanks, Dipen!
Target Milestone: --- → Thunderbird 63.0
Version: 16 → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•