1483403 - remove calls to nsICertificateDialogs.viewCert and invoke UI directly

Status: RESOLVED FIXED

(MailNews Core :: General, defect)

Description

[Dipen Patel [:dipen]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704003137

Steps to reproduce:


The Core Security::PSM interface nsICertificateDialogs.viewCert has been removed.  Update calls to invoke the UI directly. 

See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=1468225

Comment 1

[Jorg K (CEST = GMT+2)]

Thanks for the heads-up, we have two calls:

mailnews/extensions/smime/content/msgCompSecurityInfo.js
221 cd.viewCert(parent, cert);
mailnews/extensions/smime/content/msgReadSecurityInfo.js
212 cd.viewCert(parent, cert);

Comment 2

[Jorg K (CEST = GMT+2)]

Attachment: 1483403-viewCert.patch

Dipen, could you kindly review this. We can land this before bug 1468225 lands, right?

Comment 3

[Dipen Patel [:dipen]]

Comment on attachment 9001528 [details] [diff] [review]
1483403-viewCert.patch

The changes are consistent with those going in https://bugzilla.mozilla.org/show_bug.cgi?id=1468225

Looks good to me.

Comment 4

[Dipen Patel [:dipen]]

Yes it can land before https://bugzilla.mozilla.org/show_bug.cgi?id=1468225

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/222b53600d4c
Port bug 1468225: replace use of nsICertificateDialogs.viewCert. r=dipen DONTBUILD

Comment 6

[Jorg K (CEST = GMT+2)]

Thanks, Dipen!