1483480 - Delete contacts from "All address books" enabled even when write-protected contacts are selected

Status: RESOLVED WORKSFORME

(Thunderbird :: Address Book, defect)

Description

[Aref Takiden]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce:

search contact in address book, selecting it with the left mouse button, then open the context menu with the right mouse button and press delete.


Actual results:

a confirmation dialog appear, though either if I press "ok" or "cancel", nothing happens


Expected results:

the selected contact should be deleted

Comment 1

[Jorg K (CEST = GMT+2)]

Works for me. Try will add-ons disabled, see Help menu.

Comment 2

[Jorg K (CEST = GMT+2)]

Sorry, try *with* add-ons disabled, see Help menu.

Comment 3

[Aref Takiden]

I don't have any add-ons yet. it is a new fresh install with new user profile

Comment 4

[Jorg K (CEST = GMT+2)]

And which address book is selected when you search? "All Address Books" or a specific one? I tried both and both worked.

Comment 5

[Aref Takiden]

"All Address Books" is selected.
when I search on "Mac OS X Address Book", the "delete" option is even grayed out

Comment 6

[Richard Marti (:Paenglab)]

The "Mac OS X Address Book" is read only. That's why "Delete" is disabled in it. "All Address Books" should do the same. I thought we have already a bug about the "All Address Books" doesn't do it the same as the underlying AB.

Comment 7

[Aref Takiden]

I didn't know, that both "Mac OS X Address Book" and "All address Books" are read only. thank you :)

Though, when I select "All Address Books", the "Delete" option is not grayed out.

Comment 8

[Richard Marti (:Paenglab)]

"All address Books" shows, like the name says, all contacts of all existing addressbooks in one list. The problem is, it doesn't check if some addressbooks are read only and presents for all contacts the same commands.

Comment 9

[Jorg K (CEST = GMT+2)]

So can we close this bug?

Comment 10

[Richard Marti (:Paenglab)]

No, I think this is a bug of the "All address Books" implementation. Let's see what Thomas says.

Comment 11

[Thomas D. (:thomas8)]

(In reply to Richard Marti (:Paenglab) from comment #10)
> No, I think this is a bug of the "All address Books" implementation. Let's
> see what Thomas says.

Yes, this is a bug.
1) To keep it simple, if there are any write-protected contacts in the current selection, cmd_delete or whatever it is must be disabled. That provides some minimal ux-feedback in the context menu case, not in the [DEL]-key case, so users like reporter might still wonder why, as there'll be no explanation why deletion is failing/disabled. So it's just technically a bit more correct than what we have now.

Alternatively, we could leave the command enabled for mixed selections and give feedback when triggered:
2) alert the user that some contacts can't be deleted in the confirm delete message, but delete all others
3) alert the user and force him to change selection before deletion succeeds
We could even consider enabling and feedback for non-mixed read-only selections.

Maybe we could do 1) for now and think about more sophistication later.

Comment 12

[Richard Marti (:Paenglab)]

Yes, 1) is good for now and do 2) later. I think 3) is not user friendly because how should the user know which contacts are read only and which ones not.

Comment 13

[Aref Takiden]

@Richard Marti: about point 3, I totally agree. It would be very nice to see in each contact card, or next to each contact name, the address book, in which this contact lives

Comment 14

[Richard Marti (:Paenglab)]

Not near a TB to be 100% sure but this should be available when you click on the column picker on top right of the tree.

Comment 15

[Thomas D. (:thomas8)]

(In reply to Aref Takiden from comment #13)
> It would be very nice to see in each contact card, or next to each contact name,
> the address book, in which this contact lives

For all address books, I think we show the address book column by default. Seeing/changing containing AB from within the contact's card is Bug 553647.

Comment 16

[Wayne Mery (:wsmwk)]

WFM with 109 beta on Mac