1483606 - Password changes are not handled

Status: VERIFIED FIXED

(Firefox for iOS :: Sync, enhancement, P1)

Description

[Edouard Oger [:eoger]]

- Password changes initiated from Firefox iOS are not handled by the app, despite receiving the "change_password" custom event containing all that's necessary to start over.

- Password changes initiated from other devices are never "detected", even a few hours after when the token server sends 401s - aka we're never asked to reconnect ever.

The last one is really bad and might explain why some users are complaining the last sync date is never changing even when syncing manually on iOS.

Comment 1

[Edouard Oger [:eoger]]

Attachment: https://github.com/mozilla-mobile/firefox-ios/pull/4143

Mirroring the github patch

Comment 2

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/d10e4abf5656c943c86e538208bf8c56ab08c57e

Comment 3

[Justin D'Arcangelo [:justindarc]]

Catalin,
Can you check that we are testing password-change workflows? This seems to have been around for a while now. It is fixed on master.

Comment 4

[Catalin Suciu [:csuciu]]

The issue is partially fixed.

The current behavior is:
- After changing the FxA password on desktop, you're requested to re-connect on iOS only after restarting the app, not at first sync as expected. (see Bug #1484254)

- If the password is changed on iOS, you're requested to reconnect on desktop at first sync as expected.