Closed Bug 1483620 Opened Last year Closed Last year

Reader mode support broken by move to webextension page action

Categories

(Firefox :: Screenshots, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox-esr60 --- unaffected
firefox64 --- wontfix
firefox65 + verified

People

(Reporter: _6a68, Assigned: _6a68)

References

Details

(Keywords: regression)

Attachments

(1 file)

Screenshots used to work in reader mode, but the move to a webextension page action has broken that.
No longer blocks: 1483591
[Tracking Requested - why for this release]: Firefox Screenshots is migrating to a webextension in the 64 release. This is one of two UI bugs related to this change that we'd like to fix for the 64 release.
This is tracking64+ but is unassigned and hasn't been active for over two months. Given that we're only a couple weeks away from Fx64 going to RC, is this realistically on the radar for 64 at this point?
Flags: needinfo?(ddurst)
I can't speak to this, as I don't know if this requires anyone outside of Test Pilot. Jared, is this still outstanding, or moot?
Flags: needinfo?(ddurst) → needinfo?(jhirsch)
ni? :jgruen to decide what to do about this
Flags: needinfo?(jhirsch) → needinfo?(jgruen)
[Tracking Requested - why for this release]: We missed this for 64 and would like to have it fixed in 65. Thanks!
Flags: needinfo?(jgruen)
Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle.

Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression?
Flags: needinfo?(jhirsch)
Keywords: regression
> Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle.

Sure, I'll see if anyone on the addons team can help. If not, I might be able to do it with guidance. I'll update this bug with the final plan either way.

> Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression?

I guess so? That's probably a question for :jgruen, the PM for Screenshots.
Flags: needinfo?(jhirsch) → needinfo?(jgruen)
The addons team walked me through the steps to fix the bug, so I'll assign myself for 65.
Assignee: nobody → jhirsch
Status: NEW → ASSIGNED
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/8447262c404e
Screenshots pageAction should be shown on about:reader urls. r=_6a68
https://hg.mozilla.org/mozilla-central/rev/8447262c404e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
I have reproduced this bug with Nightly 63.0a1 (2018-08-15)on Windows 7, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20181207093029
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181205]
I'm clearing the needinfo, as this has been fixed and verified.
Flags: needinfo?(jgruen)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.