Closed
Bug 1483620
Opened 6 years ago
Closed 5 years ago
Reader mode support broken by move to webextension page action
Categories
(Firefox :: Screenshots, defect)
Firefox
Screenshots
Tracking
()
VERIFIED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox-esr60 | --- | unaffected |
firefox64 | --- | wontfix |
firefox65 | + | verified |
People
(Reporter: jhirsch, Assigned: jhirsch)
References
Details
(Keywords: regression)
Attachments
(1 file)
Screenshots used to work in reader mode, but the move to a webextension page action has broken that.
Assignee | ||
Comment 1•6 years ago
|
||
[Tracking Requested - why for this release]: Firefox Screenshots is migrating to a webextension in the 64 release. This is one of two UI bugs related to this change that we'd like to fix for the 64 release.
tracking-firefox64:
--- → ?
Updated•6 years ago
|
status-firefox64:
--- → affected
Comment 2•6 years ago
|
||
This is tracking64+ but is unassigned and hasn't been active for over two months. Given that we're only a couple weeks away from Fx64 going to RC, is this realistically on the radar for 64 at this point?
Flags: needinfo?(ddurst)
Comment 3•6 years ago
|
||
I can't speak to this, as I don't know if this requires anyone outside of Test Pilot. Jared, is this still outstanding, or moot?
Flags: needinfo?(ddurst) → needinfo?(jhirsch)
Assignee | ||
Comment 4•6 years ago
|
||
ni? :jgruen to decide what to do about this
Flags: needinfo?(jhirsch) → needinfo?(jgruen)
Comment 5•6 years ago
|
||
[Tracking Requested - why for this release]: We missed this for 64 and would like to have it fixed in 65. Thanks!
Updated•6 years ago
|
Flags: needinfo?(jgruen)
Comment 6•6 years ago
|
||
Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle. Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression?
Flags: needinfo?(jhirsch)
Keywords: regression
Assignee | ||
Comment 7•6 years ago
|
||
> Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle. Sure, I'll see if anyone on the addons team can help. If not, I might be able to do it with guidance. I'll update this bug with the final plan either way. > Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression? I guess so? That's probably a question for :jgruen, the PM for Screenshots.
Flags: needinfo?(jhirsch) → needinfo?(jgruen)
Assignee | ||
Comment 8•6 years ago
|
||
The addons team walked me through the steps to fix the bug, so I'll assign myself for 65.
Assignee: nobody → jhirsch
Status: NEW → ASSIGNED
Comment 9•6 years ago
|
||
Depends on D13582
Comment 10•5 years ago
|
||
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/8447262c404e Screenshots pageAction should be shown on about:reader urls. r=_6a68
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8447262c404e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment 12•5 years ago
|
||
I have reproduced this bug with Nightly 63.0a1 (2018-08-15)on Windows 7, 64 Bit! This bug's fix is verified with latest Nightly! Build ID 20181207093029 User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0
QA Whiteboard: [bugday-20181205]
Comment 13•5 years ago
|
||
I'm clearing the needinfo, as this has been fixed and verified.
Flags: needinfo?(jgruen)
Updated•5 years ago
|
Status: RESOLVED → VERIFIED
status-firefox-esr60:
--- → unaffected
Updated•5 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•