1483620 - Reader mode support broken by move to webextension page action

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Screenshots used to work in reader mode, but the move to a webextension page action has broken that.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

[Tracking Requested - why for this release]: Firefox Screenshots is migrating to a webextension in the 64 release. This is one of two UI bugs related to this change that we'd like to fix for the 64 release.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

This is tracking64+ but is unassigned and hasn't been active for over two months. Given that we're only a couple weeks away from Fx64 going to RC, is this realistically on the radar for 64 at this point?

Comment 3

[David Durst [:ddurst]]

I can't speak to this, as I don't know if this requires anyone outside of Test Pilot. Jared, is this still outstanding, or moot?

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

ni? :jgruen to decide what to do about this

Comment 5

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]: We missed this for 64 and would like to have it fixed in 65. Thanks!

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle.

Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression?

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

> Jared, can you help find someone to work on this for 65? We are nearly at the end of the 65 nightly cycle.

Sure, I'll see if anyone on the addons team can help. If not, I might be able to do it with guidance. I'll update this bug with the final plan either way.

> Do you think we should add a release note for this as a known issue, if we are going to ship 64 with this regression?

I guess so? That's probably a question for :jgruen, the PM for Screenshots.

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

The addons team walked me through the steps to fix the bug, so I'll assign myself for 65.

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1483620 - Screenshots pageAction should be shown on about:reader urls. r?_6a68!

Depends on D13582

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8447262c404e
Screenshots pageAction should be shown on about:reader urls. r=_6a68

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8447262c404e

Comment 12

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 63.0a1 (2018-08-15)on Windows 7, 64 Bit!
This bug's fix is verified with latest Nightly!

Build ID 	20181207093029
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:65.0) Gecko/20100101 Firefox/65.0

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

I'm clearing the needinfo, as this has been fixed and verified.