Closed Bug 1483810 Opened 2 years ago Closed 2 years ago

Remove obsolete .focusring styling

Categories

(Toolkit :: Themes, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dao, Assigned: devikasugathan007, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file, 3 obsolete files)

https://searchfox.org/mozilla-central/search?q=.focusring&case=true&regexp=false&path=css

This seems to be unused in mozilla-central. There are some uses in comm-central but they can add custom CSS to keep supporting this if needed.
Can I work on this issue??
(In reply to Sahil Bhosale from comment #1)
> Can I work on this issue??

I don't think there's much you can learn here anymore, this is very similar to other good first bugs that you worked on.
You are right!! 
I have already worked on this type of bugs.

I will try to work on some more advance bugs.
Can I work on this bug?
(In reply to Devika Sugathan from comment #4)
> Can I work on this bug?

Sure!
Hi, I just to delete those lines right? Please correct me if I'm wrong.
Attached patch Remove.patch (obsolete) — Splinter Review
Attachment #9002266 - Flags: review?(dao+bmo)
You also need to remove the lines in toolkit/themes/shared/tree.inc.css
Comment on attachment 9002266 [details] [diff] [review]
Remove.patch

What Tim said...
Attachment #9002266 - Flags: review?(dao+bmo)
Attached image Screenshot_20180822_195614.png (obsolete) —
I could not find the file in toolkit/themes/shared/tree.inc.css.
Attachment #9003142 - Flags: feedback?
Comment on attachment 9003142 [details]
Screenshot_20180822_195614.png

Your mozilla-central copy is probably outdated, so you'll have to update it with hg pull and hg update. Make sure you use hg pull --rebase if you have local commits, or remove your commits before updating.
Attachment #9003142 - Flags: feedback?
I have rebased it but still, I couldn't find it.
(In reply to Devika Sugathan from comment #12)
> I have rebased it but still, I couldn't find it.

what's the output of your `hg wip` ?
Attached image Screenshot_20180822_220955.png (obsolete) —
(In reply to Devika Sugathan from comment #14)
> Created attachment 9003197 [details]
> Screenshot_20180822_220955.png

Try `hg pull` then `hg rebase -d central`
Attached patch Added.patchSplinter Review
Attachment #9003142 - Attachment is obsolete: true
Attachment #9003197 - Attachment is obsolete: true
Attachment #9003225 - Flags: review?(dao+bmo)
Attachment #9002266 - Attachment is obsolete: true
Assignee: nobody → devikasugathan007
Comment on attachment 9003225 [details] [diff] [review]
Added.patch

Looks good, except for the commit message:

>Bug 1483810 Remove obsolete .focusring styling *** Changed

better:

Bug 1483810 - Remove obsolete .focusring styling. r=dao
Attachment #9003225 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ccaeab2823a2
Remove obsolete .focusring styling r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ccaeab2823a2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.