1483820 - Please compile with MSVS C++ as well on inbound and autoland since if you don't, M-C will be busted for people using that compiler locally

Status: RESOLVED WONTFIX

(Release Engineering :: General, enhancement)

Description

[Jorg K (CEST = GMT+2)]

Forgive me if this is the wrong product/component.

Please compile with MSVS C++ as well on inbound and autoland since if you don't, M-C will be busted for people using that compiler locally.

We've had three cases so far where MSVS C++ didn't compile certain code and it was only noticed when the merge to M-C had happened:

Bug 1483818, bug 1483174 and almost in bug 1415980 (but that got backed out before it hit M-C since I noticed it early enough).

Comment 1

[Masatoshi Kimura [:emk]]

How about using clang-cl for local builds? Since MSVC builds are Tier-2, breaking MSVC builds is not supposed to cause immediate back out.

Comment 2

[Jorg K (CEST = GMT+2)]

Sure, if that can be set up somehow. Honza got real upset in bug 1483174 comment #6 and talks about "Tier 1" there. I don't understand any of that tier business, but IMHO it doesn't make sense to merge to M-C and break something that will need to be fixed later anyway.

Comment 3

[(Away)]

Developers on Windows should really be using clang-cl at this point. MSVC builds are only being kept around for a little while in case some emergency prevents clang-cl from reaching mozilla-release, but even if that happens it's unlikely to delay the transition for more than one cycle. If anything, the only action item here is to make local builds default to clang-cl.

Comment 4

[Julien Cristau [:jcristau]]

Building with MSVC is no longer supported (bug 1512504).