1483174 - Permafailing z:/build/build/src/dom/media/webaudio/blink/HRTFPanner.cpp(40): error C2220: warning treated as error - no 'object' file generated

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=193824620&repo=mozilla-central

https://queue.taskcluster.net/v1/task/TWVtaMHoSPq0qTJSdcQGKA/runs/0/artifacts/public/logs/live_backing.log

10:06:34     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.6.6/VC/bin/Hostx64/x64/cl.exe -FoUnified_cpp_webaudio_blink0.obj -c -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DUSE_SSE2 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/dom/media/webaudio/blink -Iz:/build/build/src/obj-firefox/dom/media/webaudio/blink -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/dom/media/webaudio -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX    -Fdgenerated.pdb -FS  z:/build/build/src/obj-firefox/dom/media/webaudio/blink/Unified_cpp_webaudio_blink0.cpp
10:06:34     INFO -  Unified_cpp_webaudio_blink0.cpp
10:06:34     INFO -  z:/build/build/src/dom/media/webaudio/blink/HRTFPanner.cpp(40): error C2220: warning treated as error - no 'object' file generated
10:06:34     INFO -  z:/build/build/src/dom/media/webaudio/blink/HRTFPanner.cpp(40): warning C4305: 'initializing': truncation from 'double' to 'float'
10:06:34     INFO -  z:/build/build/src/config/rules.mk:1088: recipe for target 'Unified_cpp_webaudio_blink0.obj' failed
10:06:34     INFO -  mozmake.EXE[4]: *** [Unified_cpp_webaudio_blink0.obj] Error 2
10:06:34     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/dom/media/webaudio/blink'
10:06:34     INFO -  z:/build/build/src/config/recurse.mk:74: recipe for target 'dom/media/webaudio/blink/target' failed
10:06:34     INFO -  mozmake.EXE[3]: *** [dom/media/webaudio/blink/target] Error 2
10:06:34     INFO -  mozmake.EXE[3]: *** Waiting for unfinished jobs....

This appears to be a fallout from bug 1480661

Comment 1

[Andreea Pavel [:apavel]]

Karl can you please take a look?

Comment 2

[Jorg K (CEST = GMT+2)]

Yep, see bug 1480661 comment #20. MSVS C++ doesn't like it.

You really have a problem that try uses clang-cl on Windows and when it hits M-C it blows up since MSVS C++ doesn't compile on some Tier 3(?) builds.

Comment 3

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab5131f416de491e8b1668d6307797c03fb59107

Comment 4

[Karl Tomlinson (:karlt)]

Attachment: Bug 1483174 use float constants with float delay time variables r=padenot

Comment 5

[Intermittent Failures Robot]

17 failures in 594 pushes (0.029 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 11
* try: 6

Platform breakdown:
* windows2012-64: 9
* windows2012-32: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1483174&startday=2018-08-14&endday=2018-08-14&tree=all

Comment 6

[Honza Bambas (:mayhemer)]

Just updated to MozillaBuild 3.2 on Windows, bootstraped to the latest clang-cl, using the current m-c.  Build is using cl ver = 19.13.26132.

 0:09.16 checking the target C compiler version... 19.13.26132
 0:09.28 checking the target C compiler works... yes
 0:09.28 checking for the target C++ compiler... 'C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1413~1.261/bin/HostX64/x64/cl.exe'
 0:09.38 checking whether the target C++ compiler can be used... yes
 0:09.38 checking the target C++ compiler version... 19.13.26132
 0:09.44 checking the target C++ compiler works... yes
 0:09.44 checking for the host C compiler... 'C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1413~1.261/bin/HostX64/x64/cl.exe'
 0:09.48 checking whether the host C compiler can be used... yes
 0:09.48 checking the host C compiler version... 19.13.26132
 0:09.50 checking the host C compiler works... yes
 0:09.50 checking for the host C++ compiler... 'C:/PROGRA~2/MIB055~1/2017/COMMUN~1/VC/Tools/MSVC/1413~1.261/bin/HostX64/x64/cl.exe'
 0:09.54 checking whether the host C++ compiler can be used... yes
 0:09.54 checking the host C++ compiler version... 19.13.26132
 0:09.58 checking the host C++ compiler works... yes
 0:09.60 checking for 64-bit OS... yes


Result:


 7:11.34 c:/Mozilla/src/mozilla-central1/dom/media/webaudio/blink/HRTFPanner.cpp(40): error C2220: warning treated as error - no 'object' file generated
 7:11.34 c:/Mozilla/src/mozilla-central1/dom/media/webaudio/blink/HRTFPanner.cpp(40): warning C4305: 'initializing': truncation from 'double' to 'float'
 7:11.34 mozmake.EXE[4]: *** [c:/Mozilla/src/mozilla-central1/config/rules.mk:1088: Unified_cpp_webaudio_blink0.obj] Error 2
 7:11.36 mozmake.EXE[3]: *** [c:/Mozilla/src/mozilla-central1/config/recurse.mk:74: dom/media/webaudio/blink/target] Error 2


This fails for me on a Tier 1 platform -> blocker.

Comment 7

[Karl Tomlinson (:karlt)]

(In reply to Honza Bambas (:mayhemer) from comment #6)
> Just updated to MozillaBuild 3.2 on Windows, bootstraped to the latest clang-cl, using the current m-c.

> c:/Mozilla/src/mozilla-central1/dom/media/webaudio/blink/HRTFPanner.cpp(40):
> error C2220: warning treated as error - no 'object' file generated

The bug there is warnings treated as errors in a developer build.
If that is happening without explicit configuration, can you file a new bug for that please?

Comment 8

[Paul Adenot (:padenot)]

Comment on attachment 9000162 [details]
Bug 1483174 use float constants with float delay time variables r=padenot

Paul Adenot (:padenot) has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d142e35106
use float constants with float delay time variables r=padenot

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/48d142e35106

Comment 11

[Intermittent Failures Robot]

40 failures in 2672 pushes (0.015 failures/push) were associated with this bug in the last 7 days.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* try: 8
* mozilla-central: 32

Platform breakdown:
* windows2012-64: 20
* windows2012-32: 20

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1483174&startday=2018-08-13&endday=2018-08-19&tree=all