1484316 - Serialize clip-path and shape-outside using Servo.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

This will allow having to add more code for handling path() and such.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Serialize clip-path using Servo.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Serialize shape-outside with Servo.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #0)
> This will allow having to add more code for handling path() and such.

s/allow/avoid :)

Comment 4

[Boris Chiou [:boris]]

Awesome! :)

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Some fixes so that the previous patches pass try (to be sqashed).

In general this change brings us closer to Chromium. There are a bunch of new
passes here. Filed bug 1484342 for improvements to serialization that would make
a few more tests pass, but I don't think it's terribly important.

Comment 6

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9002066 [details]
Serialize clip-path using Servo.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 7

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9002067 [details]
Serialize shape-outside with Servo.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 8

[Xidorn Quan [:xidorn] UTC+11]

Comment on attachment 9002098 [details]
Some fixes so that the previous patches pass try (to be sqashed).

Xidorn Quan [:xidorn] UTC+10 has approved the revision.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53f23b446b29
Serialize clip-path and shape-outside using Servo. r=xidorn

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/12612 for changes under testing/web-platform/tests

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/53f23b446b29

Comment 13

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged