Closed Bug 1484408 Opened Last year Closed Last year

reorganize and update descriptions of a number of Layout-related components

Categories

(bugzilla.mozilla.org :: Administration, task, P1)

Staging

Tracking

()

RESOLVED FIXED

People

(Reporter: heycam, Unassigned)

References

Details

Attachments

(1 file)

After getting feedback in https://docs.google.com/document/d/1idw9zNczbCQudgcO-OxiY3xI8YxTpTEsoHdHHjJ2ao8/edit the Layout team would like to reorganize and update the descriptions of a number of Bugzilla components in the Core product.

The triage owner for any new components here can be set to svoisen@mozilla.com.
The updates are as follows:


1. CSS Parsing and Computation

Change the description to:

<p>Issues with loading CSS style sheets from the network, parsing style sheets
and style="" attributes, performing the CSS cascade, selector matching, and
producing correct computed values for CSS properties.</p>
<p>Example bugs:</p>
<ul>
  <li>toggling class name on an element does not restyle the element</li>
  <li>background-color property does not support hsl() values</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Cascading</li>
  <li>CSS Conditional</li>
  <li>CSS Logical Properties</li>
  <li>CSS Namespaces</li>
  <li>CSS Scoping</li>
  <li>CSS Style Attributes</li>
  <li>CSS Syntax</li>
  <li>CSS Values</li>
  <li>CSS Variables</li>
  <li>Media Queries</li>
  <li>Selectors</li>
</ul>


2. DOM: CSS Object Model

Change the description to:

<p>Issues with CSSOM support and other CSS-related DOM APIs. This is not the
place for most CSS bugs unless they involve scripting; for those see the CSS
and Layout components.</p>
<p>Example bugs:</p>
<ul>
  <li>document.styleSheets doesn’t include style sheets from file:// URLs</li>
  <li>crash setting element.style.color to "red"</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Font Loading</li>
  <li>CSSOM</li>
  <li>CSSOM View Module</li>
  <li>Geometry Interfaces</li>
</ul>


3. Layout

Change the description to:

<p>Issues in Layout that do not fit into any other Layout component or which
span multiple Layout components.</p>
<p>Bugs related to the top level presentation objects (pres shell, pres
context, and document viewer), the frame constructor, and the base frame
classes, as well as general issues with alignment and sizing, all belong
here.</p>


4. Layout: Block and Inline

Change the description to:

<p>Issues with core layout and geometry for basic block and inline elements.
This includes issues with ::first-letter and ::first-line.</p>
<p>Example bugs:</p>
<ul>
  <li>margins between two blocks do not collapse properly</li>
  <li>button does not align its baseline correctly with the rest of the line it’s in</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Box</li>
  <li>CSS Inline Layout</li>
</ul>


5. Layout: Floats

Change the description to:

<p>Issues with CSS floats and clearance.</p>
<p>Example bugs:</p>
<ul>
  <li>float moves to wrong position when you dynamically set "clear" property
  on ancestor</li>
  <li>inline frames without enough inline space should clear floats,
  regardless of shape-outside</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS 2.2 (§ Floats, and others)</li>
  <li>CSS Shapes</li>
</ul>


6. Layout: Form Controls

Change the description to:

<p>Issues with the layout and appearance of HTML form controls, such as
buttons, date/time pickers, select elements, and textareas.</p>
<p>Example bugs:</p>
<ul>
  <li>datepicker remains visible after tabbing out of date input field</li>
  <li>the filename field of &lt;input type=file&gt; renders incorrectly in
  vertical writing mode with dir=rtl</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>HTML (§ Forms)</li>
</ul>


7. Layout: HTML Frames

Merge this component into "Layout: Images" (which will be renamed).


8. Layout: Images

Change the description to:

<p>Issues with the CSS images and other replaced content.  This includes
loading, layout, and rendering of CSS images (such as in background-image),
and the layout of HTML img, picture, video, iframe, frame, and frameset
elements. For issues with image decoding and video playback, see the ImageLib
and Audio/Video components respectively.</p>
<p>Example bugs:</p>
<ul>
  <li>SVG as image with an intrinsic width and max-height has its width
  incorrectly scaled down by the same ratio as the height is scaled down</li>
  <li>&lt;iframe&gt; has incorrect default size in vertical writing mode</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Backgrounds</li>
  <li>CSS Images</li>
</ul>


9. Layout: Misc Code

Merge this component into "Layout".


10. Layout: R & A Pos

Rename this component to "Layout: Positioned" and change the description to:

<p>Issues with relative, absolute, fixed, and sticky positioning.</p>
<p>Example bugs:</p>
<ul>
  <li>&lt;thead&gt; with position: sticky gets stuck after scrolling down</li>
  <li>wrong absolute positioning when the containing block has a min-height
  and overflow:hidden</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Positioned Layout</li>
</ul>


11. Layout: Tables

Change the description to:

<p>Issues with table layout and rendering.</p>
<p>Example bugs:</p>
<ul>
  <li>border-style: groove not applied for tables with border-collapse:
  collapse</li>
  <li>incorrect width for table cells with padding, box-sizing: border-box,
  and table-layout: fixed</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS 2.2 (§ Tables)</li>
</ul>


12. Layout: Text

Rename this component to "Layout: Text and Fonts" and change the description to:

<p>Issues with CSS font selection, font loading, text shaping and glyph
selection, breaking, text decorations, bidirectional text processing, and
white space processing. For issues with glyph rendering and font format support,
see the Graphics: Text component.</p>
<p>Example bugs:</p>
<ul>
  <li>line-breaking code does not handle supplementary-plane characters
  properly</li>
  <li>double or wavy decoration lines are not repainted correctly if specified
  on floating first letter</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Fonts</li>
  <li>CSS Size Adjustment</li>
  <li>CSS Text</li>
  <li>CSS Text Decoration</li>
</ul>


13. Layout: View Rendering

Merge this component into "Layout: Web Painting".


14. Print Preview

Change the description to:

<p>Issues with layout and rendering a document in Print Preview mode. For
problems in printed or PDF output that do not appear in Print Preview, see the
Printing: Output component.</p<>



15. SVG

Change the description to:

<p>Issues with the layout or rendering of SVG content and interacting with the
SVG DOM.</p>
<p>Example bugs:</p>
<ul>
  <li>SVG marker can not be clipped with clip-path</li>
  <li>x position adjustments of SVG vertical text on a path moves in the wrong
  direction</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>SVG</li>
</ul>


16. CSS Animations and Transitions

Add this new component with description:

<p>Issues with animating and transitioning CSS properties. For issues with the
Web Animations API, see the DOM: Animations component.</p>
<p>Example bugs:</p>
<ul>
  <li>transitions are not triggered when the display property is changed
  simultaneously</li>
  <li>the font-weight property animates discretely but should be interpolated
  smoothly</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Animations</li>
  <li>CSS Timing</li>
  <li>CSS Transitions</li>
  <li>Motion Path</li>
</ul>


17. Layout: Scrolling and Overflow

Add this new component with description:

<p>Issues with the layout and rendering of scrollable elements, scrollbars,
and with the handling of overflowing content. Also includes issues with
rendering of the regular text caret and the accessible caret. For problems
with rendering of currently scrolling elements, see the Panning and Zooming
component.</p>
<p>Example bugs:</p>
<ul>
  <li>&lt;legend&gt; w/ display:flex overflow:scroll sometimes renders without
  scrollbars</li>
  <li>overflow: hidden on fieldsets spills over</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Scroll Anchoring</li>
  <li>CSS Scroll Snap</li>
  <li>CSS Scrollbars</li>
  <li>CSS Overflow</li>
</ul>


18. Layout: Columns

Add this new component with description:

<p>Issues with CSS multi-column layout.</p>
<p>Example bugs:</p>
<ul>
  <li>column rules are not properly drawn on overflow columns</li>
  <li>column gap should be included in minimum width calculation when the
  number of columns is non-auto</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Multicol</li>
</ul>


19. Layout: Flexbox

Add this new component with description:

<p>Issues with CSS flexible box layout.</p>
<p>Example bugs:</p>
<ul>
  <li>flex items not wrapping in multi-line flexbox with "overflow:hidden"</li>
  <li>baseline for empty flexbox container seems wrong</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Flexbox</li>
</ul>


20. Layout: Generated Content, Lists, and Counters

Add this new component with description:

<p>Issues with handling of CSS generated content, list items, and counters.</p>
<p>Example bugs:</p>
<ul>
  <li>::before and ::after are not rendered correctly on &lt;details&gt;</li>
  <li>list item bullet characters don't display in the specified font face</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Counter Styles</li>
  <li>CSS Generated Content</li>
  <li>CSS Lists</li>
  <li>CSS Pseudo-Elements</li>
</ul>


21. Layout: Grid

Add this new component with description:

<p>Issues with CSS grid layout.</p>
<p>Example bugs:</p>
<ul>
  <li>stretching the inline size of &lt;button&gt; grid items doesn't work</li>
  <li>abspos child of a grid should respect "align-self"/"justify-self" when
  computing its static position</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Grid Layout</li>
</ul>


22. Layout: Ruby

Add this new component with description:

<p>Issues with CSS Ruby text layout.</p>
<p>Example bugs:</p>
<ul>
  <li>ruby annotation is not placed correctly for RTL content</li>
  <li>ruby base after a line break may disappear</li>
</ul>
<p>Specifications covered:</p>
<ul>
  <li>CSS Ruby</li>
</ul>


23. Graphics: Text

Change the description to:

<p>Issues with glyph rasterization and painting, font format support, and
interfacing with platform font APIs.  For issues with font selection, text
shaping, and glyph selection, see the Layout: Text and Fonts component.</p>
The new components are all refinements of existing ones, but for now, we won't move any existing bugs into them.  I'll leave that up to those who will be taking ownership of them.
Thank you for providing the new descriptions. 

I've updated the descriptions and created the new components. 

Two things:

1. For the components to be merged:

* Layout: Frames
* Layout: Misc Code
* Layout: View Rendering

I've disabled new bug creation in them and and set the description to explain that new bugs should be created in the target components. 

Should the bugs in these components be bulk moved to the new components? That can be done without sending bugmail.

2. For the new components, I made you the triage owner. Please update this bug with a list of any changes you want to the triage owners.
Flags: needinfo?(cam)
(In reply to Emma Humphries, Bugmaster ☕️🎸🧞‍♀️✨ (she/her) [:emceeaich] (UTC-8) needinfo? me from comment #3)
> 1. For the components to be merged:
> 
> * Layout: Frames
> * Layout: Misc Code
> * Layout: View Rendering
> 
> I've disabled new bug creation in them and and set the description to
> explain that new bugs should be created in the target components. 
> 
> Should the bugs in these components be bulk moved to the new components?
> That can be done without sending bugmail.

Yes, that would be great, thank you.

> 2. For the new components, I made you the triage owner. Please update this
> bug with a list of any changes you want to the triage owners.

svoisen@mozilla.com can be made the triage owner of the new components for now.  We might adjust the triage owners of all the Layout components some time soon, but we will do that in a new bug.

Thanks!
Flags: needinfo?(cam)
(In reply to Cameron McCormack (:heycam) (away 24 Aug) from comment #4)
> > Should the bugs in these components be bulk moved to the new components?
> > That can be done without sending bugmail.
> 
> Yes, that would be great, thank you.

After that those bugs have been moved, is it possible to hide or delete the old components?  Or maybe it's appropriate to move them to the Graveyard?  It would be nice for them to no longer appear in e.g. https://bugzilla.mozilla.org/describecomponents.cgi?product=Core or in the Component list box on show_bug.cgi.
(In reply to Cameron McCormack (:heycam) (away 24 Aug) from comment #5)

> After that those bugs have been moved, is it possible to hide or delete the
> old components?  Or maybe it's appropriate to move them to the Graveyard? 
> It would be nice for them to no longer appear in e.g.
> https://bugzilla.mozilla.org/describecomponents.cgi?product=Core or in the
> Component list box on show_bug.cgi.

Yes, we can remove them from describecomponents.cgi and show_bug.cgi once we move these.
(In reply to Cameron McCormack (:heycam) (away 24 Aug) from comment #4)

> svoisen@mozilla.com can be made the triage owner of the new components for
> now.  We might adjust the triage owners of all the Layout components some
> time soon, but we will do that in a new bug.

I've done that. 

Keeping the bug open while we get the bugs moved and components closed out.
Thanks.  Just to check, you'll also do the component renamings mentioned in comment 1 once that's done?
Hi Emma - Yes, I'm good with owning triage on these new (and merged) components.
A bunch of components have been moved to "Core Graveyard" without their bugs being moved into the new components.  This mass-move is causing confusion (e.g., in bug 132035) and may also be causing important bugs to be omitted from queries, searches, etc.  It seems like moving the bugs into the correct components (in the correct product) should be a high priority.
What happened to the Layout: Images component? Into what component shall bugs get filed which got created in Layout: Images before the change.
Flags: needinfo?(ehumphries)
:mcote and I are reviewing the changes made and determining what needs to be reverted.
Flags: needinfo?(ehumphries)
(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #12)

> What happened to the Layout: Images component? Into what component shall
> bugs get filed which got created in Layout: Images before the change.

There should be a "Layout: Images, Video, and HTML Frames" component when all of this is resolved.

The final list of components should be:

CSS Animations and Transitions
CSS Parsing and Computation
DOM: CSS Object Model
Layout
Layout: Block and Inline
Layout: Columns
Layout: Flexbox
Layout: Floats
Layout: Form Controls
Layout: Generated Content, Lists, and Counters
Layout: Grid
Layout: Images, Video, and HTML Frames
Layout: Positioned
Layout: Ruby
Layout: Scrolling and Overflow
Layout: Tables
Layout: Text and Fonts
Print Preview
Printing: Output
Printing: Setup
SVG
Seems the majority of this hsa been done with the following exceptions:

(In reply to Sean Voisen (:svoisen) from comment #14)
> The final list of components should be:
> 
> CSS Animations and Transitions
> CSS Parsing and Computation
> DOM: CSS Object Model
> Layout
> Layout: Block and Inline
> Layout: Columns
> Layout: Flexbox
> Layout: Floats
> Layout: Form Controls
> Layout: Generated Content, Lists, and Counters
> Layout: Grid
> Layout: Images, Video, and HTML Frames

This is currently named 'Layout: Images'. I assume this still needs to be renamed to 'Layout: Images, Video, and HTML Frames'?

> Layout: Positioned
> Layout: Ruby
> Layout: Scrolling and Overflow
> Layout: Tables
> Layout: Text and Fonts

There is also 'Layout: Web Painting' which is not listed here. Does that stay as-is?

> Print Preview
> Printing: Output
> Printing: Setup
> SVG

Anything else that needs to be done other than the 'Layout: Images' rename?

dkl
Flags: needinfo?(svoisen)
(In reply to David Lawrence [:dkl] from comment #15)
> This is currently named 'Layout: Images'. I assume this still needs to be
> renamed to 'Layout: Images, Video, and HTML Frames'?

Yes.

> There is also 'Layout: Web Painting' which is not listed here. Does that
> stay as-is?

Yes, that stays as is.  (And has the "Layout: View Rendering" bugs moved into it.)

> > Print Preview
> > Printing: Output
> > Printing: Setup
> > SVG
> 
> Anything else that needs to be done other than the 'Layout: Images' rename?

That looks like the only rename that hasn't been done.
(In reply to Cameron McCormack (:heycam) from comment #16)
> (In reply to David Lawrence [:dkl] from comment #15)
> > This is currently named 'Layout: Images'. I assume this still needs to be
> > renamed to 'Layout: Images, Video, and HTML Frames'?
> 
> Yes.
> 

Done

> > There is also 'Layout: Web Painting' which is not listed here. Does that
> > stay as-is?
> 
> Yes, that stays as is.  (And has the "Layout: View Rendering" bugs moved
> into it.)
> 

Yep.

> > > Print Preview
> > > Printing: Output
> > > Printing: Setup
> > > SVG
> > 
> > Anything else that needs to be done other than the 'Layout: Images' rename?
> 
> That looks like the only rename that hasn't been done.

ok. so this might be ready to close up. Just verify for us.

https://bugzilla.mozilla.org/describecomponents.cgi?product=Core
Flags: needinfo?(svoisen) → needinfo?(cam)
Looks good, thanks very much.
Flags: needinfo?(cam)
Great
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Attachment #9002642 - Flags: feedback?(svoisen) → feedback+
You need to log in before you can comment on or make changes to this bug.