1484644 - Investigate whitelisting xul attribute tooltiptext in DOM overlays

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Axel Hecht [:Pike]]

We currently only allow tooltiptext on toolbarbutton.

But we use it on richlistitem, image, and button, at least, too.

Some picked up data-l10n-attrs to explicitly whitelist it, some apparently don't:

https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/sync.xul#79
https://dxr.mozilla.org/mozilla-central/source/browser/components/preferences/in-content/privacy.xul#328

Is this also something where we can bust tests if we strip attributes?

Comment 1

[Axel Hecht [:Pike]]

Looking at https://dxr.mozilla.org/mozilla-central/source/dom/webidl/XULElement.webidl#65, tooltiptext is defined on xul element, so we should probably add it to general?

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

yeah, totally. Anyone wants to write a patch? :)

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Can you also whitelist `title` on `window`?

Here are attributes we manually whitelist: https://searchfox.org/mozilla-central/search?q=data-l10n-attrs&path=

I think `style` should remain whitelisted per case, but title definitely can be added to the global whitelist.

Comment 4

[Collin Wing]

Attachment: Bug 1484644 Whitelist title and tooltiptext for XUL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67a3276d3b4e
Whitelist title and tooltiptext for XUL r=zbraniecki

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/67a3276d3b4e