1484698 - Rename hasFxAccount to usesFirefoxSync in AS Targeting

Status: RESOLVED FIXED

(Firefox :: Messaging System, enhancement, P2)

Description

[Kate Hudson :k88hudson]

See https://github.com/mozmeao/snippets-service/issues/650#issuecomment-414266333.

May need some further discussion

Comment 1

[Giorgos Logiotatidis [:giorgos]]

Is this something we can get for Fx63?

If not is it OK to include both hasFxAccount and usesFirefoxSync in the JEXL. E.g.

'isDefaultBrowser == true && hasFxAccount == false && usesFirefoxSync == false'

Comment 2

[Andrei Oprea [:andreio]]

In order to capture any of the two attributes and check for `true` you should use something like this: `isDefaultBrowser == true && (hasFxAccount == true || usesFirefoxSync == true)`

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4421

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/3735e08facc3584a4b2a7f906449684c9f75bf74
Fix Bug 1484698 - Rename hasFxAccount to usesFirefoxSync (#4421)

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/8dde92f89a24

Comment 6

[Ed Lee :Mardak]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout

Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70