1484708 - .gitignore rules are incorrect

Status: RESOLVED FIXED

(Developer Infrastructure :: Developer Environment Integration, enhancement)

Description

[Ashley Hauck [:khyperia]]

Merging two issues into one, because they're quite minor updates to .gitignore:

.hgignore includes the following lines:

# Build directories for js shell
_DBG\.OBJ/
_OPT\.OBJ/
^js/src/.*-obj/

.gitignore includes the following lines:

# Build directories for js shell
_DBG.OBJ/
_OPT.OBJ/

The .gitignore lines *should* be `*_DBG.OBJ/` (asterisk in front), as .gitignore syntax matches the entire file/folder name, and so needs a glob up front. Right now, it only matches literally `_DBG.OBJ`, and not e.g. `build_DBG.OBJ`.

Additionally, .gitignore includes `.vscode/*`. This should be `.vscode/` (no asterisk), since the current rule means "exclude all files within .vscode, but *include* the .vscode folder *itself*". This isn't a problem with the root .vscode, but if there's a .vscode elsewhere in tree (in my case, `js/src/.vscode`), git will want to add the folder (but no files within it).

(Note there's already reverse-excludes(?) for `.vscode/extensions.json` and `.vscode/tasks.json`)

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Update .gitignore rules.

Comment 2

[Ted Campbell [:tcampbell]]

Would be nice to include obj-* for js/src too. I think this convention is used for the project root ignores.

Comment 3

[Ashley Hauck [:khyperia]]

Attachment: Update .gitignore rules.

Comment 4

[Ashley Hauck [:khyperia]]

(In reply to Ted Campbell [:tcampbell] from comment #2)
> Would be nice to include obj-* for js/src too. I think this convention is
> used for the project root ignores.

(it's *-obj - the .hgignore is `^js/src/.*-obj/`. Attached new patch that adds `/js/src/**/*-obj/`)

Comment 5

[Ashley Hauck [:khyperia]]

Attachment: Update .gitignore rules and add js/src/obj-*.

Comment 6

[Ted Campbell [:tcampbell]]

Cool. This covers the cases I was thinking of :)

Comment 7

[(not currently active) Ted Mielczarek]

Comment on attachment 9002517 [details] [diff] [review]
Update .gitignore rules and add js/src/obj-*.

Review of attachment 9002517 [details] [diff] [review]:
-----------------------------------------------------------------

It's so fun when two tools use similar-looking patterns that are actually different. :) Thanks for fixing this up!

Comment 8

[(not currently active) Ted Mielczarek]

Also FYI: in the future you might want to request review from :build-peer , which is the shared review queue for build peers. If you don't need review from a specific person it's usually faster (we triage it at our team meeting every week).

Comment 9

[Ashley Hauck [:khyperia]]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #8)
> Also FYI: in the future you might want to request review from :build-peer ,
> which is the shared review queue for build peers. If you don't need review
> from a specific person it's usually faster (we triage it at our team meeting
> every week).

Thanks! I appreciate the info :)

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ead8943575c9
Update .gitignore rules and add js/src/obj-*. r=ted.mielczarek

Comment 11

[Tiberius Oros[:tiberius_oros]]

https://hg.mozilla.org/mozilla-central/rev/ead8943575c9