1484955 - Switch about:neterror and about:certerror to use Fluent

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

The way we do currently use strings in about:net/certerror is just atrocious. We put all of them in a .dtd and inject them into hidden elements on the page to copy the correct string over into a visible element using .innerHTML. This solution was acceptable for a long time since we lacked a good alternative, but with Fluent coming to untrusted content pages I would really like to end the suffering and use that instead.

Comment 1

[Johann Hofmann [:johannh]]

One caveat, though: We should only do this after we have completed the work in bug 1463693 and the error pages are un-forked again.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Now that bug 1517528 is complete, the amount of manual work to do this conversion should be drastically reduced, allowing us to do the conversion on both forks in an acceptable amount of time. Nick, can you use the conversion script you worked on in bug 1517528 to fix this bug?

Comment 3

[Francesco Lodolo [:flod]]

This is blocked by work on Fluent's side, e.g. https://github.com/projectfluent/fluent.js/issues/288

Comment 4

[Johann Hofmann [:johannh]]

FYI we're unforking in bug 1530348, but probably only in 68

Comment 5

[Axel Hecht [:Pike]]

Having talked with flod some more, here's our suggestion on how to move forward here:

Let's localize individual phrases, and drop the hole thing about using big changing fragments. We don't want localizers to change the list items anyway. The work in about:blocked is a good inspiration for this.

Given we might not be able to migrate a lot of strings, we can also be more flexible about what the neterror page does after the migration. If you start tackling this bug, loop in Michelle Heubusch for input on that.

Comment 6

[Johann Hofmann [:johannh]]

Prathiksha has been doing this as part of her internship project.

Comment 7

[Eemeli Aro [:eemeli]]

This should get fixed by patch D155951 for bug 1734217.