1484965 - [de-xbl] Remove nobuttons binding

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, task)

Comment 1

[Arshad Khan [:arshad]]

Attachment: nobuttons.patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9002740 [details] [diff] [review]
nobuttons.patch

This patch is in chat/ so philipp is not the correct reviewer.

The patch doesn't work though. Set up two accounts and notice the buttons do not go away once selecting another.

I think it would be useful to put your analysis of why you can remove it into the bug comments.

Comment 3

[Patrick Cloke [:clokep]]

Thanks for taking a look at this! :florian or :nhnt11 can most likely review this for you. (I can as a last resort, they both know XBL/XUL much better than me!)

Comment 4

[Richard Marti (:Paenglab)]

The bindings could be removed from both rules and then with:

richlistitem .account-buttons {
  display: none;
}
richlistitem[selected="true"] .account-buttons {
  display: -moz-box;
}

this should work.

Comment 5

[Arshad Khan [:arshad]]

Attachment: nobuttons.patch

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 9006239 [details] [diff] [review]
nobuttons.patch

Review of attachment 9006239 [details] [diff] [review]:
-----------------------------------------------------------------

Yep this works, thx!
Since this is chat/ maybe florian still wants to r+ it?

Comment 7

[Florian Quèze [:florian]]

Comment on attachment 9006239 [details] [diff] [review]
nobuttons.patch

r+ because the patch looks like it will work, but it's not obvious that this is an improvement. If the goal is to move away from xbl, it's the account.xml#account binding that you want to find a replacement for.

Comment 8

[Magnus Melin [:mkmelin]]

Well, one step at the time - this makes it one less thing to consider.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/7953345b93f6
Remove nobuttons binding. r=florian,Paenglab DONTBUILD