Move AccessibleCaret preferences to StaticPrefList.h

RESOLVED FIXED in Firefox 64

Status

()

defect
P4
normal
RESOLVED FIXED
10 months ago
9 months ago

People

(Reporter: TYLin, Assigned: TYLin)

Tracking

(Blocks 2 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(4 attachments)

Assignee

Comment 2

9 months ago
"layers.async-pan-zoom.enabled" has been enabled for all platforms for a
long time. I reword the comment to avoid confusion.
Assignee

Updated

9 months ago
Assignee: nobody → aethanyc
Status: NEW → ASSIGNED

Comment 5

9 months ago
Comment on attachment 9007906 [details]
Bug 1485063 Part 1 - Move preferences used in AccessibleCaret to StaticPrefsList.h

Mats Palmgren (:mats) has approved the revision.
Attachment #9007906 - Flags: review+

Comment 6

9 months ago
Comment on attachment 9007908 [details]
Bug 1485063 Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h

Mats Palmgren (:mats) has approved the revision.
Attachment #9007908 - Flags: review+

Comment 7

9 months ago
Comment on attachment 9007909 [details]
Bug 1485063 Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h

Mats Palmgren (:mats) has approved the revision.
Attachment #9007909 - Flags: review+

Comment 8

9 months ago
Comment on attachment 9007911 [details]
Bug 1485063 Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h

Mats Palmgren (:mats) has approved the revision.
Attachment #9007911 - Flags: review+

Comment 9

9 months ago
Hmm, I wonder why we started using snake_case for StaticPrefs names in the first place...
Assignee

Comment 10

9 months ago
(In reply to Mats Palmgren (:mats) from comment #9)
> Hmm, I wonder why we started using snake_case for StaticPrefs names in the
> first place...

Snake_case is recommanded in the document [1], and so far layout prefs has been following that. Media has different opinions to use CamelCase though. See the discussion in bug 1448222 comment 5 and bug 1448222 comment 11.

[1] https://searchfox.org/mozilla-central/rev/d4ef4e9747133aa2914aca2a15cf9df1e42a6aa0/modules/libpref/init/StaticPrefList.h#61-66

Comment 12

9 months ago
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b4e402e76ba6
Part 1 - Move preferences used in AccessibleCaret to StaticPrefsList.h r=mats
https://hg.mozilla.org/integration/autoland/rev/f42f853c8aa7
Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h. r=mats
https://hg.mozilla.org/integration/autoland/rev/1edf90819cb2
Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h. r=mats
https://hg.mozilla.org/integration/autoland/rev/fdd2f4fc6d5a
Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h. r=mats

Comment 13

9 months ago
(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #10)
> Snake_case is recommanded in the document [1], and so far layout prefs has
> been following that. Media has different opinions to use CamelCase though.
> See the discussion in bug 1448222 comment 5 and bug 1448222 comment 11.

Thanks, I filed bug 1490161.
Additional retriggers proved this was intermittent: https://tinyurl.com/y7eo3nkg

Relanding the patches. 

Ting-Yu we apologize for this.
Assignee

Comment 16

9 months ago
Andreea, no worries. Thank you for keeping the tree green.

BTW, I don't see a push log for relanding yet. I'll reland my patches to autoland.
Flags: needinfo?(aethanyc)
Assignee

Comment 17

9 months ago
Well, lando seems to have bugs to reland patch series. Filed bug 1490407. I'll reland them to inbound later.

Comment 18

9 months ago
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d43869851540
Part 1 - Move preferences used in AccessibleCaret to StaticPrefsList.h r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/99456cff7313
Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f53e771094d
Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h. r=mats
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ad3af468d26
Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h. r=mats

Comment 20

9 months ago
backout
Backed out for causing bug 1490818.
https://hg.mozilla.org/mozilla-central/rev/2603d8004c78b79c8c8c6f789d752a11700cf841
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: mozilla64 → ---
Assignee

Comment 21

9 months ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #20)
> Backed out for causing bug 1490818.
> https://hg.mozilla.org/mozilla-central/rev/
> 2603d8004c78b79c8c8c6f789d752a11700cf841

I was flipping the pref "layout.accessiblecaret.enabled_on_touch" to false in Part 3. That's why the selection won't work in bug 1490818.
Assignee

Comment 22

9 months ago
I'll correct Part 3, and land those patches again.
Attachment #9007908 - Attachment description: Bug 1485063 Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h. → Bug 1485063 Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h
Attachment #9007909 - Attachment description: Bug 1485063 Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h. → Bug 1485063 Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h
Attachment #9007911 - Attachment description: Bug 1485063 Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h. → Bug 1485063 Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h

Comment 23

9 months ago
Pushed by aethanyc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9a90cc08d56d
Part 1 - Move preferences used in AccessibleCaret to StaticPrefsList.h r=mats
https://hg.mozilla.org/integration/autoland/rev/f1426745e933
Part 2 - Move preferences used in AccessibleCaretEventHub to StaticPrefList.h r=mats
https://hg.mozilla.org/integration/autoland/rev/253db3bbd64f
Part 3 - Move preferences which enable AccessibleCaret to StaticPrefList.h r=mats
https://hg.mozilla.org/integration/autoland/rev/df8cf3e01392
Part 4 - Move preferences used in AccessibleCaretManager to StaticPrefList.h r=mats

Comment 24

9 months ago
(In reply to Ting-Yu Lin [:TYLin] (UTC-7) from comment #21)
> I was flipping the pref "layout.accessiblecaret.enabled_on_touch" to false
> in Part 3. 

Please try to backtrack your steps to figure out how that happened
so that you can avoid it in the future.  It's a bit scary if
unintentional code changes happens after the review like this.
Assignee

Comment 25

9 months ago
I make the mistake from the beginning when moving the prefs, not after the patches were reviewed. Anyway, it's my bad for not testing on a real Android device. Also filed Bug 1493317 for further investigation.

Comment 26

9 months ago
Ah, my bad for not catching that in the review then.
Depends on: 1494002
Blocks: 1448219
Summary: Move AccessibleCaret prefereneces to StaticPrefList.h → Move AccessibleCaret preferences to StaticPrefList.h
Depends on: 1493955
You need to log in before you can comment on or make changes to this bug.