1485319 - Write the FILE_AS_BINARY case of FileReader::DoReadData in terms of SetCapacity and AppendASCIItoUTF16

Status: RESOLVED FIXED

(Core :: DOM: File, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

FileReader::DoReadData calls nsTSubstring::GetMutableData, which is a rarely used redundant API that would be nice to remove as a clean-up (bug 1485026).

Also, the code does low-level writes via a pointer to mResult's buffer. This code could be written more cleanly with SetCapacity() and AppendASCIItoUTF16(). (Although the latter says "ASCII", it actually performs the Latin1 to UTF-16 conversion, i.e. zero-extends each byte to a char16_t.)

Comment 1

[Andrea Marchesini [:baku]]

Subhamoy, do you have time to work on this?

Comment 2

[Subhamoy [:ssengupta][he/him]]

Attachment: Bug 1485319 - P1 - Call to nsTSubstring::GetMutableData removed r=baku

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66b62186b533
P1 - Call to nsTSubstring::GetMutableData removed r=baku

Comment 4

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/66b62186b533