Closed Bug 1485508 Opened 2 years ago Closed 2 years ago

MozParams aren't supported as the first entry in a search engine

Categories

(Firefox :: Search, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 64
Tracking Status
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

If a MozParam is the first entry in an engine, the searchForm ends up as:

http://foo.com?&foo=bar
Blocks: 1484232
Priority: -- → P1
Comment on attachment 9003491 [details]
Bug 1485508 - Properly construct MozParameterized search URL.

Drew Willcoxon :adw has approved the revision.
Attachment #9003491 - Flags: review+
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/5740e53a5e2d
Properly construct MozParameterized search URL. r=adw
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed6d2eaccfe
Properly construct MozParameterized search URL. r=adw
> It might be possible to use https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams for this.

I did think about using that but it seemed like overkill for this case.
https://hg.mozilla.org/mozilla-central/rev/5740e53a5e2d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Does this need a Beta uplift or can it ride the trains?
Flags: needinfo?(mozilla)
Riding the trains.
Flags: needinfo?(mozilla)
You need to log in before you can comment on or make changes to this bug.