1485508 - MozParams aren't supported as the first entry in a search engine

Status: RESOLVED FIXED

(Firefox :: Search, enhancement, P1)

Description

[Mike Kaply [:mkaply]]

If a MozParam is the first entry in an engine, the searchForm ends up as:

http://foo.com?&foo=bar

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1485508 - Properly construct MozParameterized search URL.

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 9003491 [details]
Bug 1485508 - Properly construct MozParameterized search URL.

Drew Willcoxon :adw has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5740e53a5e2d
Properly construct MozParameterized search URL. r=adw

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed6d2eaccfe
Properly construct MozParameterized search URL. r=adw

Comment 5

[Tom S. (please needinfo tschuster)]

It might be possible to use https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams for this.

Comment 6

[Mike Kaply [:mkaply]]

> It might be possible to use https://developer.mozilla.org/en-US/docs/Web/API/URLSearchParams for this.

I did think about using that but it seemed like overkill for this case.

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5740e53a5e2d

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/0ed6d2eaccfe

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift or can it ride the trains?

Comment 10

[Mike Kaply [:mkaply]]

Riding the trains.